Re: [Qemu-devel] [PATCHv2] esp: Do not overwrite ESP_TCHI after reset

2014-11-11 Thread Hannes Reinecke
On 11/11/2014 01:37 PM, Paolo Bonzini wrote: > > > On 10/11/2014 21:11, Hannes Reinecke wrote: >> On 11/10/2014 07:32 PM, Paolo Bonzini wrote: >>> On 10/11/2014 16:52, Hannes Reinecke wrote: After a reset ESP_TCHI should contain the unique ID of the chip. This value will be overwritten

Re: [Qemu-devel] [PATCHv2] esp: Do not overwrite ESP_TCHI after reset

2014-11-11 Thread Paolo Bonzini
On 10/11/2014 21:11, Hannes Reinecke wrote: > On 11/10/2014 07:32 PM, Paolo Bonzini wrote: >> On 10/11/2014 16:52, Hannes Reinecke wrote: >>> After a reset ESP_TCHI should contain the unique ID >>> of the chip. This value will be overwritten with the >>> current tranfer count if the transfer coun

Re: [Qemu-devel] [PATCHv2] esp: Do not overwrite ESP_TCHI after reset

2014-11-10 Thread Hannes Reinecke
On 11/10/2014 07:32 PM, Paolo Bonzini wrote: > On 10/11/2014 16:52, Hannes Reinecke wrote: >> After a reset ESP_TCHI should contain the unique ID >> of the chip. This value will be overwritten with the >> current tranfer count if the transfer count has >> previously been set. >> So we should always

Re: [Qemu-devel] [PATCHv2] esp: Do not overwrite ESP_TCHI after reset

2014-11-10 Thread Paolo Bonzini
On 10/11/2014 16:52, Hannes Reinecke wrote: > After a reset ESP_TCHI should contain the unique ID > of the chip. This value will be overwritten with the > current tranfer count if the transfer count has > previously been set. > So we should always return the chip id if ESP_TCHI > has never been wri

[Qemu-devel] [PATCHv2] esp: Do not overwrite ESP_TCHI after reset

2014-11-10 Thread Hannes Reinecke
After a reset ESP_TCHI should contain the unique ID of the chip. This value will be overwritten with the current tranfer count if the transfer count has previously been set. So we should always return the chip id if ESP_TCHI has never been written to. Signed-off-by: Hannes Reinecke --- hw/scsi/e