Re: [Qemu-devel] [PATCH v9 2/3] pl330: Initial version

2013-02-18 Thread Peter Crosthwaite
Hi Peter, All comments addressed. V10 on list soon: changed from v9: s/dma/DMA in patch subject s/PL330/PL330State/ (PMM review) Fixed 80 char violation (PMM review) Fixed pl330_queue_put_insn prototype indentation (PMM review) s/DEVICE_LITTLE_ENDIAN/DEVICE_NATIVE_ENDIAN (PMM review) Made more QO

Re: [Qemu-devel] [PATCH v9 2/3] pl330: Initial version

2013-02-18 Thread Peter Maydell
On 8 February 2013 03:42, Peter Crosthwaite wrote: > Device model for Primecell PL330 dma controller. > +typedef struct PL330 PL330; This struct and typedef should be named "PL330State" -- "PL330" is needed for the name of the standard QOM cast macro (see below). > +/* Initialize queue */ > +st

[Qemu-devel] [PATCH v9 2/3] pl330: Initial version

2013-02-07 Thread Peter Crosthwaite
Device model for Primecell PL330 dma controller. Signed-off-by: Peter Crosthwaite Signed-off-by: Kirill Batuzov Tested-by: Igor Mitsyanko --- changed from v9: s/sysbus_from_qdev/SYS_BUS_DEVICE (rebase) Fixed include names (rebase) Reworked debug instrumentation Added level 2 debug hexdumper (du