Re: [Qemu-devel] [PATCH v9 05/37] vl: Improve use of qapi visitor

2016-01-20 Thread Markus Armbruster
Eric Blake writes: > On 01/20/2016 06:43 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Cache the visitor in a local variable instead of repeatedly >>> calling the accessor. Pass NULL for the visit_start_struct() >>> object (which matches the fact that we were already passing 0 >>>

Re: [Qemu-devel] [PATCH v9 05/37] vl: Improve use of qapi visitor

2016-01-20 Thread Eric Blake
On 01/20/2016 06:43 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Cache the visitor in a local variable instead of repeatedly >> calling the accessor. Pass NULL for the visit_start_struct() >> object (which matches the fact that we were already passing 0 >> for the size argument, becaus

Re: [Qemu-devel] [PATCH v9 05/37] vl: Improve use of qapi visitor

2016-01-20 Thread Markus Armbruster
Eric Blake writes: > Cache the visitor in a local variable instead of repeatedly > calling the accessor. Pass NULL for the visit_start_struct() > object (which matches the fact that we were already passing 0 > for the size argument, because we aren't using the visit to > allocate a qapi struct).

[Qemu-devel] [PATCH v9 05/37] vl: Improve use of qapi visitor

2016-01-19 Thread Eric Blake
Cache the visitor in a local variable instead of repeatedly calling the accessor. Pass NULL for the visit_start_struct() object (which matches the fact that we were already passing 0 for the size argument, because we aren't using the visit to allocate a qapi struct). Guarantee that visit_end_stru