Re: [Qemu-devel] [PATCH v9 05/14] hw/arm/smmuv3: Wired IRQ and GERROR helpers

2018-03-09 Thread Auger Eric
Hi Peter, On 09/03/18 15:18, Peter Maydell wrote: > On 9 March 2018 at 14:03, Auger Eric wrote: >> On 08/03/18 18:49, Peter Maydell wrote: +#define smmuv3_eventq_irq_enabled(s) \ +(FIELD_EX32(s->irq_ctrl, IRQ_CTRL, EVENTQ_IRQEN)) +#define smmuv3_gerror_irq_ena

Re: [Qemu-devel] [PATCH v9 05/14] hw/arm/smmuv3: Wired IRQ and GERROR helpers

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 14:03, Auger Eric wrote: > On 08/03/18 18:49, Peter Maydell wrote: >>> +#define smmuv3_eventq_irq_enabled(s) \ >>> +(FIELD_EX32(s->irq_ctrl, IRQ_CTRL, EVENTQ_IRQEN)) >>> +#define smmuv3_gerror_irq_enabled(s) \ >>> +(FIELD_EX32(s->irq_ct

Re: [Qemu-devel] [PATCH v9 05/14] hw/arm/smmuv3: Wired IRQ and GERROR helpers

2018-03-09 Thread Auger Eric
Hi Peter, On 08/03/18 18:49, Peter Maydell wrote: > On 17 February 2018 at 18:46, Eric Auger wrote: >> We introduce some helpers to handle wired IRQs and especially >> GERROR interrupt. SMMU writes GERROR register on GERROR event >> and SW acks GERROR interrupts by setting GERRORn. >> >> The Wire

Re: [Qemu-devel] [PATCH v9 05/14] hw/arm/smmuv3: Wired IRQ and GERROR helpers

2018-03-08 Thread Peter Maydell
On 17 February 2018 at 18:46, Eric Auger wrote: > We introduce some helpers to handle wired IRQs and especially > GERROR interrupt. SMMU writes GERROR register on GERROR event > and SW acks GERROR interrupts by setting GERRORn. > > The Wired interrupts are edge sensitive hence the pulse usage. > >

[Qemu-devel] [PATCH v9 05/14] hw/arm/smmuv3: Wired IRQ and GERROR helpers

2018-02-17 Thread Eric Auger
We introduce some helpers to handle wired IRQs and especially GERROR interrupt. SMMU writes GERROR register on GERROR event and SW acks GERROR interrupts by setting GERRORn. The Wired interrupts are edge sensitive hence the pulse usage. Signed-off-by: Eric Auger --- v7 -> v8: - remove SMMU_PEN