Re: [Qemu-devel] [PATCH v9 04/12] migration: Start of multiple fd work

2017-12-09 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> +static void multifd_new_channel_async(QIOTask *task, gpointer opaque) >> +{ >> +MultiFDSendParams *p = opaque; >> +QIOChannel *sioc = QIO_CHANNEL(qio_task_get_source(task)); >> +Error *local_err; > > Do

Re: [Qemu-devel] [PATCH v9 04/12] migration: Start of multiple fd work

2017-10-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We create new channels for each new thread created. We send through > them a string containing multifd so we are > sure that we connect the right channels in both sides. > > Signed-off-by: Juan Quintela > > -- > Split SocketArgs into incoming and

Re: [Qemu-devel] [PATCH v9 04/12] migration: Start of multiple fd work

2017-10-09 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Wed, Oct 04, 2017 at 12:46:28PM +0200, Juan Quintela wrote: >> We create new channels for each new thread created. We send through >> them a string containing multifd so we are >> sure that we connect the right channels in both sides. > > This message needs updat

Re: [Qemu-devel] [PATCH v9 04/12] migration: Start of multiple fd work

2017-10-09 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Wed, Oct 04, 2017 at 12:46:28PM +0200, Juan Quintela wrote: >> We create new channels for each new thread created. We send through >> them a string containing multifd so we are >> sure that we connect the right channels in both sides. > > This message needs updat

Re: [Qemu-devel] [PATCH v9 04/12] migration: Start of multiple fd work

2017-10-09 Thread Daniel P. Berrange
On Wed, Oct 04, 2017 at 12:46:28PM +0200, Juan Quintela wrote: > We create new channels for each new thread created. We send through > them a string containing multifd so we are > sure that we connect the right channels in both sides. This message needs updating now that we send a struct. > di

Re: [Qemu-devel] [PATCH v9 04/12] migration: Start of multiple fd work

2017-10-09 Thread Peter Xu
On Wed, Oct 04, 2017 at 12:46:28PM +0200, Juan Quintela wrote: > We create new channels for each new thread created. We send through > them a string containing multifd so we are Need to touch-up the commit message to reflect the new protocol? > sure that we connect the right channels in both si

[Qemu-devel] [PATCH v9 04/12] migration: Start of multiple fd work

2017-10-04 Thread Juan Quintela
We create new channels for each new thread created. We send through them a string containing multifd so we are sure that we connect the right channels in both sides. Signed-off-by: Juan Quintela -- Split SocketArgs into incoming and outgoing args Use UUID's on the initial message, so we are s