Re: [Qemu-devel] [PATCH v9 03/17] qapi: Reserve 'u' and 'has[-_]*' member names

2015-10-21 Thread Markus Armbruster
Eric Blake writes: > On 10/19/2015 11:19 AM, Markus Armbruster wrote: > >> I'm not quite comfortable with reserving 'u' now, becaue I feel we >> haven't fully explored the design space for avoiding branch - member >> clashes. >> >> I still like the basic idea to give the unnamed union a name. I

Re: [Qemu-devel] [PATCH v9 03/17] qapi: Reserve 'u' and 'has[-_]*' member names

2015-10-20 Thread Eric Blake
On 10/19/2015 11:19 AM, Markus Armbruster wrote: > I'm not quite comfortable with reserving 'u' now, becaue I feel we > haven't fully explored the design space for avoiding branch - member > clashes. > > I still like the basic idea to give the unnamed union a name. It needs > to be a short one,

Re: [Qemu-devel] [PATCH v9 03/17] qapi: Reserve 'u' and 'has[-_]*' member names

2015-10-19 Thread Markus Armbruster
Eric Blake writes: > To make collision detection between member names easier, we > might as well reject all attempts to use anything that would > collide with our use of 'has_' as a flag for optional members. > Also, a later patch will introduce a named union 'u' for > holding the branch names of

[Qemu-devel] [PATCH v9 03/17] qapi: Reserve 'u' and 'has[-_]*' member names

2015-10-15 Thread Eric Blake
To make collision detection between member names easier, we might as well reject all attempts to use anything that would collide with our use of 'has_' as a flag for optional members. Also, a later patch will introduce a named union 'u' for holding the branch names of a qapi union in a separate nam