Re: [Qemu-devel] [PATCH v9 01/10] Add cache handling functions

2012-04-19 Thread Amos Kong
On Thu, Apr 12, 2012 at 2:49 AM, Orit Wasserman wrote: > Add LRU page cache mechanism. > The page are accessed by their address. > > Signed-off-by: Orit Wasserman > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > --- > arch_init.c | 220 > +++

Re: [Qemu-devel] [PATCH v9 01/10] Add cache handling functions

2012-04-18 Thread Orit Wasserman
On 04/18/2012 08:19 PM, Anthony Liguori wrote: > On 04/11/2012 01:49 PM, Orit Wasserman wrote: >> Add LRU page cache mechanism. >> The page are accessed by their address. >> >> Signed-off-by: Orit Wasserman >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >> Signed-off-by: Aidan Shrib

Re: [Qemu-devel] [PATCH v9 01/10] Add cache handling functions

2012-04-18 Thread Juan Quintela
Orit Wasserman wrote: > On 04/18/2012 05:34 PM, Juan Quintela wrote: >>> +assert(cache_num_buckets); >>> +DPRINTF("Setting cache buckets to %lu\n", cache_num_buckets); >>> + >>> +assert(!page_cache); >> >> Only user of this function make page_cache = NULL before calling. >> Returning

Re: [Qemu-devel] [PATCH v9 01/10] Add cache handling functions

2012-04-18 Thread Anthony Liguori
On 04/11/2012 01:49 PM, Orit Wasserman wrote: Add LRU page cache mechanism. The page are accessed by their address. Signed-off-by: Orit Wasserman Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman --- arch_init.c | 220 ++

Re: [Qemu-devel] [PATCH v9 01/10] Add cache handling functions

2012-04-18 Thread Orit Wasserman
On 04/18/2012 05:34 PM, Juan Quintela wrote: > Orit Wasserman wrote: >> Add LRU page cache mechanism. >> The page are accessed by their address. >> >> + >> +typedef struct CacheItem { >> +ram_addr_t it_addr; >> +unsigned long it_age; >> +uint8_t *it_data; >> +} CacheItem; >> + >> +type

Re: [Qemu-devel] [PATCH v9 01/10] Add cache handling functions

2012-04-18 Thread Juan Quintela
Orit Wasserman wrote: > Add LRU page cache mechanism. > The page are accessed by their address. > > + > +typedef struct CacheItem { > +ram_addr_t it_addr; > +unsigned long it_age; > +uint8_t *it_data; > +} CacheItem; > + > +typedef struct CacheBucket { > +CacheItem bkt_item[CACHE_N

[Qemu-devel] [PATCH v9 01/10] Add cache handling functions

2012-04-11 Thread Orit Wasserman
Add LRU page cache mechanism. The page are accessed by their address. Signed-off-by: Orit Wasserman Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman --- arch_init.c | 220 +++ 1 files changed, 220 i