Re: [Qemu-devel] [PATCH v8 20/35] qmp: Don't abuse stack to track qmp-output root

2016-01-05 Thread Marc-André Lureau
Hi On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote: > The previous commit documented an inconsistency in how we are > using the stack of qmp-output-visitor. Normally, pushing a > single top-level object puts the object on the stack twice: > once as the root, and once as the current container b

[Qemu-devel] [PATCH v8 20/35] qmp: Don't abuse stack to track qmp-output root

2015-12-21 Thread Eric Blake
The previous commit documented an inconsistency in how we are using the stack of qmp-output-visitor. Normally, pushing a single top-level object puts the object on the stack twice: once as the root, and once as the current container being appended to; but popping that struct only pops once. Howev