Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-04-10 Thread Peter Xu
On Tue, Apr 10, 2018 at 03:15:57PM +0800, Peter Xu wrote: > On Mon, Apr 09, 2018 at 11:19:43AM +0200, Marc-André Lureau wrote: > > Hi > > > > On Sun, Apr 8, 2018 at 5:02 AM, Peter Xu wrote: > > > On Wed, Apr 04, 2018 at 03:58:56PM +0200, Marc-André Lureau wrote: > > >> Hi Peter > > >> > > >> On W

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-04-10 Thread Peter Xu
On Mon, Apr 09, 2018 at 11:19:43AM +0200, Marc-André Lureau wrote: > Hi > > On Sun, Apr 8, 2018 at 5:02 AM, Peter Xu wrote: > > On Wed, Apr 04, 2018 at 03:58:56PM +0200, Marc-André Lureau wrote: > >> Hi Peter > >> > >> On Wed, Mar 28, 2018 at 6:02 AM, Peter Xu wrote: > >> > On Mon, Mar 26, 2018

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-04-09 Thread Marc-André Lureau
Hi On Sun, Apr 8, 2018 at 5:02 AM, Peter Xu wrote: > On Wed, Apr 04, 2018 at 03:58:56PM +0200, Marc-André Lureau wrote: >> Hi Peter >> >> On Wed, Mar 28, 2018 at 6:02 AM, Peter Xu wrote: >> > On Mon, Mar 26, 2018 at 11:46:13AM +0200, Marc-André Lureau wrote: >> >> Hi >> >> >> >> On Mon, Mar 26,

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-04-07 Thread Peter Xu
On Wed, Apr 04, 2018 at 03:58:56PM +0200, Marc-André Lureau wrote: > Hi Peter > > On Wed, Mar 28, 2018 at 6:02 AM, Peter Xu wrote: > > On Mon, Mar 26, 2018 at 11:46:13AM +0200, Marc-André Lureau wrote: > >> Hi > >> > >> On Mon, Mar 26, 2018 at 11:08 AM, Peter Xu wrote: > >> > On Mon, Mar 26, 201

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-04-04 Thread Marc-André Lureau
Hi Peter On Wed, Mar 28, 2018 at 6:02 AM, Peter Xu wrote: > On Mon, Mar 26, 2018 at 11:46:13AM +0200, Marc-André Lureau wrote: >> Hi >> >> On Mon, Mar 26, 2018 at 11:08 AM, Peter Xu wrote: >> > On Mon, Mar 26, 2018 at 10:33:27AM +0200, Marc-André Lureau wrote: >> >> Hi >> >> >> >> On Mon, Mar 26

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-03-27 Thread Peter Xu
On Mon, Mar 26, 2018 at 11:46:13AM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Mar 26, 2018 at 11:08 AM, Peter Xu wrote: > > On Mon, Mar 26, 2018 at 10:33:27AM +0200, Marc-André Lureau wrote: > >> Hi > >> > >> On Mon, Mar 26, 2018 at 10:07 AM, Peter Xu wrote: > >> > On Fri, Mar 23, 2018 at

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-03-26 Thread Marc-André Lureau
Hi On Mon, Mar 26, 2018 at 11:08 AM, Peter Xu wrote: > On Mon, Mar 26, 2018 at 10:33:27AM +0200, Marc-André Lureau wrote: >> Hi >> >> On Mon, Mar 26, 2018 at 10:07 AM, Peter Xu wrote: >> > On Fri, Mar 23, 2018 at 05:18:53PM +0100, Marc-André Lureau wrote: >> > >> > [...] >> > >> >> > +/* >> >> >

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-03-26 Thread Peter Xu
On Mon, Mar 26, 2018 at 10:33:27AM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Mar 26, 2018 at 10:07 AM, Peter Xu wrote: > > On Fri, Mar 23, 2018 at 05:18:53PM +0100, Marc-André Lureau wrote: > > > > [...] > > > >> > +/* > >> > + * Dispatch one single QMP request. The function will free the

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-03-26 Thread Marc-André Lureau
Hi On Mon, Mar 26, 2018 at 10:07 AM, Peter Xu wrote: > On Fri, Mar 23, 2018 at 05:18:53PM +0100, Marc-André Lureau wrote: > > [...] > >> > +/* >> > + * Dispatch one single QMP request. The function will free the req_obj >> > + * and objects inside it before return. >> > + */ >> > +static void mon

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-03-26 Thread Peter Xu
On Fri, Mar 23, 2018 at 05:18:53PM +0100, Marc-André Lureau wrote: [...] > > +/* > > + * Dispatch one single QMP request. The function will free the req_obj > > + * and objects inside it before return. > > + */ > > +static void monitor_qmp_dispatch_one(QMPRequest *req_obj) > > { > > -QObject

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-03-23 Thread Marc-André Lureau
On Fri, Mar 9, 2018 at 9:59 AM, Peter Xu wrote: > Originally QMP goes through these steps: > > JSON Parser --> QMP Dispatcher --> Respond > /|\(2)(3) | >(1) | \|/ (4) >+- main thread + > > This patch does t

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-03-22 Thread Eric Blake
On 03/22/2018 12:00 AM, Peter Xu wrote: Doesn't OOB insist on having an ID field with the command? OOB insists on an id field - but there is the situation that SOME errors occur even before the id field has been encountered (for example, if you send non-JSON, the parser gets all confused - it

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-03-21 Thread Peter Xu
On Thu, Mar 22, 2018 at 12:32:36AM +0100, Marc-André Lureau wrote: > Hi > > On Wed, Mar 21, 2018 at 9:33 PM, Eric Blake wrote: > > On 03/21/2018 03:09 PM, Dr. David Alan Gilbert wrote: > > > > So the parsing job and the dispatching job is isolated now. It gives us > a chance in fo

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-03-21 Thread Marc-André Lureau
Hi On Wed, Mar 21, 2018 at 9:33 PM, Eric Blake wrote: > On 03/21/2018 03:09 PM, Dr. David Alan Gilbert wrote: > So the parsing job and the dispatching job is isolated now. It gives us a chance in following up patches to totally move the parser outside. The isolation is d

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-03-21 Thread Eric Blake
On 03/21/2018 03:09 PM, Dr. David Alan Gilbert wrote: So the parsing job and the dispatching job is isolated now. It gives us a chance in following up patches to totally move the parser outside. The isolation is done using one QEMUBH. Only one dispatcher QEMUBH is used for all the monitors.

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-03-21 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Fri, Mar 9, 2018 at 9:59 AM, Peter Xu wrote: > > Originally QMP goes through these steps: > > > > JSON Parser --> QMP Dispatcher --> Respond > > /|\(2)(3) | > >(1) |

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-03-21 Thread Marc-André Lureau
Hi On Fri, Mar 9, 2018 at 9:59 AM, Peter Xu wrote: > Originally QMP goes through these steps: > > JSON Parser --> QMP Dispatcher --> Respond > /|\(2)(3) | >(1) | \|/ (4) >+- main thread + > > This patch do

Re: [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-03-10 Thread Eric Blake
On 03/09/2018 02:59 AM, Peter Xu wrote: Originally QMP goes through these steps: JSON Parser --> QMP Dispatcher --> Respond /|\(2)(3) | (1) | \|/ (4) +- main thread + This patch does this: JSON Par

[Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher

2018-03-09 Thread Peter Xu
Originally QMP goes through these steps: JSON Parser --> QMP Dispatcher --> Respond /|\(2)(3) | (1) | \|/ (4) +- main thread + This patch does this: JSON Parser QMP Dispatcher --> Respond /|\ |