Re: [Qemu-devel] [PATCH v8 13/13] target/arm: Send interrupts on PMU counter overflow

2018-11-30 Thread Richard Henderson
On 11/30/18 11:57 AM, Aaron Lindsay wrote: >> Eh? But we've set overflow_mask based on PMCR.LC, so what you say here >> doesn't >> make sense. > > Sorry, I had an off-by-one-bit think-o I couldn't get past until I > started typing a concrete example to explain myself. I'll change this > line to

Re: [Qemu-devel] [PATCH v8 13/13] target/arm: Send interrupts on PMU counter overflow

2018-11-30 Thread Aaron Lindsay
On Nov 30 10:19, Richard Henderson wrote: > On 11/30/18 9:56 AM, Aaron Lindsay wrote: > > On Nov 30 09:13, Richard Henderson wrote: > >> On 11/20/18 1:26 PM, Aaron Lindsay wrote: > >>> Setup a QEMUTimer to get a callback when we expect counters to next > >>> overflow and trigger an interrupt at tha

Re: [Qemu-devel] [PATCH v8 13/13] target/arm: Send interrupts on PMU counter overflow

2018-11-30 Thread Richard Henderson
On 11/30/18 9:56 AM, Aaron Lindsay wrote: > On Nov 30 09:13, Richard Henderson wrote: >> On 11/20/18 1:26 PM, Aaron Lindsay wrote: >>> Setup a QEMUTimer to get a callback when we expect counters to next >>> overflow and trigger an interrupt at that time. >>> >>> Signed-off-by: Aaron Lindsay >>> Si

Re: [Qemu-devel] [PATCH v8 13/13] target/arm: Send interrupts on PMU counter overflow

2018-11-30 Thread Aaron Lindsay
On Nov 30 09:13, Richard Henderson wrote: > On 11/20/18 1:26 PM, Aaron Lindsay wrote: > > Setup a QEMUTimer to get a callback when we expect counters to next > > overflow and trigger an interrupt at that time. > > > > Signed-off-by: Aaron Lindsay > > Signed-off-by: Aaron Lindsay > > --- > > tar

Re: [Qemu-devel] [PATCH v8 13/13] target/arm: Send interrupts on PMU counter overflow

2018-11-30 Thread Richard Henderson
On 11/20/18 1:26 PM, Aaron Lindsay wrote: > Setup a QEMUTimer to get a callback when we expect counters to next > overflow and trigger an interrupt at that time. > > Signed-off-by: Aaron Lindsay > Signed-off-by: Aaron Lindsay > --- > target/arm/cpu.c| 12 + > target/arm/cpu.h| 7

[Qemu-devel] [PATCH v8 13/13] target/arm: Send interrupts on PMU counter overflow

2018-11-20 Thread Aaron Lindsay
Setup a QEMUTimer to get a callback when we expect counters to next overflow and trigger an interrupt at that time. Signed-off-by: Aaron Lindsay Signed-off-by: Aaron Lindsay --- target/arm/cpu.c| 12 + target/arm/cpu.h| 7 +++ target/arm/helper.c | 126 +++