Re: [Qemu-devel] [PATCH v8 04/13] tests: Add a test key pair

2017-09-18 Thread Fam Zheng
On Mon, 09/18 10:17, Eric Blake wrote: > On 09/17/2017 09:43 PM, Fam Zheng wrote: > > This will be used by setup test user ssh. > > Shouldn't the commit message have more details about WHY we are checking > in a private key? The conversation last time included useful gems such as: > > Some guests

Re: [Qemu-devel] [PATCH v8 04/13] tests: Add a test key pair

2017-09-18 Thread Eric Blake
On 09/17/2017 09:43 PM, Fam Zheng wrote: > This will be used by setup test user ssh. Shouldn't the commit message have more details about WHY we are checking in a private key? The conversation last time included useful gems such as: Some guests require the key to exist prior to provisioning the g

[Qemu-devel] [PATCH v8 04/13] tests: Add a test key pair

2017-09-17 Thread Fam Zheng
This will be used by setup test user ssh. Signed-off-by: Fam Zheng --- tests/keys/id_rsa | 27 +++ tests/keys/id_rsa.pub | 1 + 2 files changed, 28 insertions(+) create mode 100644 tests/keys/id_rsa create mode 100644 tests/keys/id_rsa.pub diff --git a/tests/keys/