On Thu, 3 Mar 2016 12:52:17 -0500
Matthew Rosato wrote:
> >> +S390CPU *s390_new_cpu(MachineState *machine, int64_t id, Error **errp)
> >> +{
> >> +S390CPU *cpu = NULL;
> >> +Error *local_err = NULL;
> >
> > Think the naming schema is "err" now.
> >
> >> +
> >> +if (id >= max_cpu
>> +S390CPU *s390_new_cpu(MachineState *machine, int64_t id, Error **errp)
>> +{
>> +S390CPU *cpu = NULL;
>> +Error *local_err = NULL;
>
> Think the naming schema is "err" now.
>
>> +
>> +if (id >= max_cpus) {
>> +error_setg(errp, "Unable to add CPU: %" PRIi64
>> +
> >> +static void s390_cpu_get_id(Object *obj, Visitor *v, const char *name,
> >> +void *opaque, Error **errp)
> >> +{
> >> +S390CPU *cpu = S390_CPU(obj);
> >> +int64_t value = cpu->id;
> >> +
> >> +visit_type_int(v, name, &value, errp);
> >> +}
> >> +
> >> +
On 03/02/2016 02:59 AM, David Hildenbrand wrote:
>> Check for and propogate errors during s390 cpu creation.
>>
>> Signed-off-by: Matthew Rosato
>> ---
>> hw/s390x/s390-virtio-ccw.c | 30 +
>> hw/s390x/s390-virtio.c | 2 +-
>> hw/s390x/s390-virtio.h | 1 +
>> target-
>> +static void s390_cpu_get_id(Object *obj, Visitor *v, const char *name,
>> +void *opaque, Error **errp)
>> +{
>> +S390CPU *cpu = S390_CPU(obj);
>> +int64_t value = cpu->id;
>> +
>> +visit_type_int(v, name, &value, errp);
>> +}
>> +
>> +static void s390_cpu
> Check for and propogate errors during s390 cpu creation.
>
> Signed-off-by: Matthew Rosato
> ---
> hw/s390x/s390-virtio-ccw.c | 30 +
> hw/s390x/s390-virtio.c | 2 +-
> hw/s390x/s390-virtio.h | 1 +
> target-s390x/cpu-qom.h | 3 +++
> target-s390x/cpu.c
> Check for and propogate errors during s390 cpu creation.
>
> Signed-off-by: Matthew Rosato
> ---
> hw/s390x/s390-virtio-ccw.c | 30 +
> hw/s390x/s390-virtio.c | 2 +-
> hw/s390x/s390-virtio.h | 1 +
> target-s390x/cpu-qom.h | 3 +++
> target-s390x/cpu.c
Check for and propogate errors during s390 cpu creation.
Signed-off-by: Matthew Rosato
---
hw/s390x/s390-virtio-ccw.c | 30 +
hw/s390x/s390-virtio.c | 2 +-
hw/s390x/s390-virtio.h | 1 +
target-s390x/cpu-qom.h | 3 +++
target-s390x/cpu.c | 65 ++
