Re: [Qemu-devel] [PATCH v7 4/4] hw: convert virtio-input-hid device to keycodemapdb

2018-01-25 Thread Daniel P . Berrangé
On Thu, Jan 25, 2018 at 04:16:19PM +0100, Gerd Hoffmann wrote: > Hi, > > > If the guest OS reboots, or otherwise re-initializes the virt-input device, > > it will read the new keycode bitmap. No matter how many keys are defined, > > the config space has a fixed 128 byte bitmap. There is, however

Re: [Qemu-devel] [PATCH v7 4/4] hw: convert virtio-input-hid device to keycodemapdb

2018-01-25 Thread Gerd Hoffmann
Hi, > If the guest OS reboots, or otherwise re-initializes the virt-input device, > it will read the new keycode bitmap. No matter how many keys are defined, > the config space has a fixed 128 byte bitmap. There is, however, a size > field defiend which says how many bytes in the bitmap are used

Re: [Qemu-devel] [PATCH v7 4/4] hw: convert virtio-input-hid device to keycodemapdb

2018-01-17 Thread Michael S. Tsirkin
On Wed, Jan 17, 2018 at 01:02:07PM -0600, Eric Blake wrote: > On 01/17/2018 10:41 AM, Daniel P. Berrange wrote: > > Replace the keymap_qcode table with automatically generated > > tables. > > > > Missing entries in keymap_qcode now fixed: > > > > > > > When a keycode is removed from the list of

Re: [Qemu-devel] [PATCH v7 4/4] hw: convert virtio-input-hid device to keycodemapdb

2018-01-17 Thread Eric Blake
On 01/17/2018 10:41 AM, Daniel P. Berrange wrote: > Replace the keymap_qcode table with automatically generated > tables. > > Missing entries in keymap_qcode now fixed: > > > When a keycode is removed from the list of possible keycodes that host can > send to the guest, it means that the guest

[Qemu-devel] [PATCH v7 4/4] hw: convert virtio-input-hid device to keycodemapdb

2018-01-17 Thread Daniel P. Berrange
Replace the keymap_qcode table with automatically generated tables. Missing entries in keymap_qcode now fixed: Q_KEY_CODE_ASTERISK -> KEY_KPASTERISK Q_KEY_CODE_KP_MULTIPLY -> KEY_KPASTERISK Q_KEY_CODE_STOP -> KEY_STOP Q_KEY_CODE_AGAIN -> KEY_AGAIN Q_KEY_CODE_PROPS -> KEY_PROPS Q_KEY_C