Re: [Qemu-devel] [PATCH v7 3/5] shutdown: Add source information to SHUTDOWN and RESET

2017-05-10 Thread Markus Armbruster
Eric Blake writes: > On 05/09/2017 06:56 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Time to wire up all the call sites that request a shutdown or >>> reset to use the enum added in the previous patch. >>> >>> It would have been less churn to keep the common case with no >>> argum

Re: [Qemu-devel] [PATCH v7 3/5] shutdown: Add source information to SHUTDOWN and RESET

2017-05-09 Thread Markus Armbruster
Resending because first send didn't get through to some recipients... Eric Blake writes: > Time to wire up all the call sites that request a shutdown or > reset to use the enum added in the previous patch. > > It would have been less churn to keep the common case with no > arguments as meaning g

Re: [Qemu-devel] [PATCH v7 3/5] shutdown: Add source information to SHUTDOWN and RESET

2017-05-09 Thread Eric Blake
On 05/09/2017 06:56 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Time to wire up all the call sites that request a shutdown or >> reset to use the enum added in the previous patch. >> >> It would have been less churn to keep the common case with no >> arguments as meaning guest-triggere

Re: [Qemu-devel] [PATCH v7 3/5] shutdown: Add source information to SHUTDOWN and RESET

2017-05-09 Thread Cornelia Huck
On Mon, 8 May 2017 16:19:51 -0500 Eric Blake wrote: > Time to wire up all the call sites that request a shutdown or > reset to use the enum added in the previous patch. > > It would have been less churn to keep the common case with no > arguments as meaning guest-triggered, and only modified th

[Qemu-devel] [PATCH v7 3/5] shutdown: Add source information to SHUTDOWN and RESET

2017-05-08 Thread Eric Blake
Time to wire up all the call sites that request a shutdown or reset to use the enum added in the previous patch. It would have been less churn to keep the common case with no arguments as meaning guest-triggered, and only modified the host-triggered code paths, via a wrapper function, but then we'