Re: [Qemu-devel] [PATCH v7 3/3] qcow2: Discard unaligned tail when wiping image

2017-03-31 Thread Eric Blake
On 03/31/2017 09:01 AM, Max Reitz wrote: >>Do I need to >> respin for that, or is it something a maintainer could tweak, or is the >> series fine as-is? > > Of course I can fix the code, but changing the commit messages is a bit > more i

Re: [Qemu-devel] [PATCH v7 3/3] qcow2: Discard unaligned tail when wiping image

2017-03-31 Thread Max Reitz
On 31.03.2017 15:56, Eric Blake wrote: > On 03/31/2017 07:51 AM, Max Reitz wrote: >> On 31.03.2017 00:36, Eric Blake wrote: >>> The previous commit pointed out a subtle difference between the >>> fast and slow path of qcow2_make_empty(), where we failed to discard >>> the final (partial) cluster of

Re: [Qemu-devel] [PATCH v7 3/3] qcow2: Discard unaligned tail when wiping image

2017-03-31 Thread Eric Blake
On 03/31/2017 07:51 AM, Max Reitz wrote: > On 31.03.2017 00:36, Eric Blake wrote: >> The previous commit pointed out a subtle difference between the >> fast and slow path of qcow2_make_empty(), where we failed to discard >> the final (partial) cluster of an unaligned image. >> >> +/* The calle

Re: [Qemu-devel] [PATCH v7 3/3] qcow2: Discard unaligned tail when wiping image

2017-03-31 Thread Max Reitz
On 31.03.2017 00:36, Eric Blake wrote: > The previous commit pointed out a subtle difference between the > fast and slow path of qcow2_make_empty(), where we failed to discard > the final (partial) cluster of an unaligned image. > > The problem stems from the fact that qcow2_discard_clusters() was

[Qemu-devel] [PATCH v7 3/3] qcow2: Discard unaligned tail when wiping image

2017-03-30 Thread Eric Blake
The previous commit pointed out a subtle difference between the fast and slow path of qcow2_make_empty(), where we failed to discard the final (partial) cluster of an unaligned image. The problem stems from the fact that qcow2_discard_clusters() was silently ignoring sub-cluster head and tail on u