Re: [Qemu-devel] [PATCH v7 2/2] dump: Turn some functions to void to make code cleaner

2014-10-08 Thread zhanghailiang
On 2014/10/8 22:57, Eric Blake wrote: On 09/30/2014 03:20 AM, zhanghailiang wrote: Functions shouldn't return an error code and an Error object at the same time. Turn all these functions that returning Error object to void. We also judge if a function success or fail by reference to the local_er

Re: [Qemu-devel] [PATCH v7 2/2] dump: Turn some functions to void to make code cleaner

2014-10-08 Thread Eric Blake
On 09/30/2014 03:20 AM, zhanghailiang wrote: > Functions shouldn't return an error code and an Error object at the same time. > Turn all these functions that returning Error object to void. > We also judge if a function success or fail by reference to the local_err. > > Signed-off-by: zhanghailian

Re: [Qemu-devel] [PATCH v7 2/2] dump: Turn some functions to void to make code cleaner

2014-10-07 Thread zhanghailiang
Hi, Ping...:( Thanks, zhanghailiang On 2014/9/30 17:20, zhanghailiang wrote: Functions shouldn't return an error code and an Error object at the same time. Turn all these functions that returning Error object to void. We also judge if a function success or fail by reference to the local_err.

[Qemu-devel] [PATCH v7 2/2] dump: Turn some functions to void to make code cleaner

2014-09-30 Thread zhanghailiang
Functions shouldn't return an error code and an Error object at the same time. Turn all these functions that returning Error object to void. We also judge if a function success or fail by reference to the local_err. Signed-off-by: zhanghailiang --- dump.c | 313 ++