Re: [Qemu-devel] [PATCH v7 18/38] ahci-test: Drop dependence on global_qtest

2017-09-11 Thread John Snow
On 09/11/2017 08:20 PM, John Snow wrote: > > > On 09/11/2017 01:20 PM, Eric Blake wrote: >> Managing parallel connections to two different monitors via >> the implicit global_qtest makes it hard to copy-and-paste code >> to tests that are not aware of the implicit state; the >> management of gl

Re: [Qemu-devel] [PATCH v7 18/38] ahci-test: Drop dependence on global_qtest

2017-09-11 Thread John Snow
On 09/11/2017 01:20 PM, Eric Blake wrote: > Managing parallel connections to two different monitors via > the implicit global_qtest makes it hard to copy-and-paste code > to tests that are not aware of the implicit state; the > management of global_qtest is even harder to follow because > it was

[Qemu-devel] [PATCH v7 18/38] ahci-test: Drop dependence on global_qtest

2017-09-11 Thread Eric Blake
Managing parallel connections to two different monitors via the implicit global_qtest makes it hard to copy-and-paste code to tests that are not aware of the implicit state; the management of global_qtest is even harder to follow because it was masked behind set_context(). Instead, explicitly pass