Re: [Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-28 Thread Peter Crosthwaite
Looks good to me, Peter On Fri, Jun 29, 2012 at 3:56 PM, Jia Liu wrote: > Hi Peter, > > On Fri, Jun 29, 2012 at 11:15 AM, Peter Crosthwaite > wrote: >> On Thu, Jun 28, 2012 at 11:56 PM, Jia Liu wrote: >>> Hi, Peter, Andreas, and Peter, >>> >>> I've replace env with cpu, and rewrite the load_ke

Re: [Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-28 Thread Jia Liu
Hi Peter, On Fri, Jun 29, 2012 at 11:15 AM, Peter Crosthwaite wrote: > On Thu, Jun 28, 2012 at 11:56 PM, Jia Liu wrote: >> Hi, Peter, Andreas, and Peter, >> >> I've replace env with cpu, and rewrite the load_kernel. >> Please review these new files: >> >> openrisc_pic.c >> >> #include "hw.h" >>

Re: [Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-28 Thread Jia Liu
On Fri, Jun 29, 2012 at 11:03 AM, 陳韋任 (Wei-Ren Chen) wrote: >> /* OpenRISC pic handler */ >> static void openrisc_pic_cpu_handler(void *opaque, int irq, int level) >> { >> OpenRISCCPU *cpu = (OpenRISCCPU *)opaque; > ^^ > Do we need casting before assigning

Re: [Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-28 Thread Peter Crosthwaite
On Thu, Jun 28, 2012 at 11:56 PM, Jia Liu wrote: > Hi, Peter, Andreas, and Peter, > > I've replace env with cpu, and rewrite the load_kernel. > Please review these new files: > > openrisc_pic.c > > #include "hw.h" > #include "cpu.h" > > /* OpenRISC pic handler */ > static void openrisc_pic_cpu_han

Re: [Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-28 Thread Wei-Ren Chen
> /* OpenRISC pic handler */ > static void openrisc_pic_cpu_handler(void *opaque, int irq, int level) > { > OpenRISCCPU *cpu = (OpenRISCCPU *)opaque; ^^ Do we need casting before assigning opaque to cpu? Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Sy

Re: [Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-28 Thread Jia Liu
Hi, Peter, Andreas, and Peter, I've replace env with cpu, and rewrite the load_kernel. Please review these new files: openrisc_pic.c #include "hw.h" #include "cpu.h" /* OpenRISC pic handler */ static void openrisc_pic_cpu_handler(void *opaque, int irq, int level) { OpenRISCCPU *cpu = (OpenR

Re: [Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-27 Thread Peter Crosthwaite
On Wed, Jun 27, 2012 at 11:04 PM, Andreas Färber wrote: > Am 27.06.2012 14:25, schrieb Peter Crosthwaite: >> Hi Jia, >> >> On Wed, Jun 27, 2012 at 7:54 PM, Jia Liu wrote: >>> +static void openrisc_sim_init(ram_addr_t ram_size, >>> +                              const char *boot_device, >>> +    

Re: [Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-27 Thread Andreas Färber
Am 27.06.2012 14:25, schrieb Peter Crosthwaite: > Hi Jia, > > On Wed, Jun 27, 2012 at 7:54 PM, Jia Liu wrote: >> +static void openrisc_sim_init(ram_addr_t ram_size, >> + const char *boot_device, >> + const char *kernel_filename, >> +

Re: [Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-27 Thread Peter Crosthwaite
Hi Jia, On Wed, Jun 27, 2012 at 7:54 PM, Jia Liu wrote: > Add a IIS dummy board. > > Signed-off-by: Jia Liu > --- >  hw/openrisc/Makefile.objs |    2 +- >  hw/openrisc_sim.c         |  149 > + >  2 files changed, 150 insertions(+), 1 deletion(-) >  cr

[Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-27 Thread Jia Liu
Add a IIS dummy board. Signed-off-by: Jia Liu --- hw/openrisc/Makefile.objs |2 +- hw/openrisc_sim.c | 149 + 2 files changed, 150 insertions(+), 1 deletion(-) create mode 100644 hw/openrisc_sim.c diff --git a/hw/openrisc/Makefile.objs b