Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
- Original Message - > Hi, > > >> Maybe revisit upstream spice packaging? spice internal usage of > >> spice-protocol is handled via submodules now. Are there external > >> users, other than qemu? Does it make sense to keep the > >> spice-server / spice-protocol split in the first pla

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Gerd Hoffmann
Hi, >> Maybe revisit upstream spice packaging? spice internal usage of >> spice-protocol is handled via submodules now. Are there external >> users, other than qemu? Does it make sense to keep the >> spice-server / spice-protocol split in the first place? Or should >> spice-server just pro

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
On Sat, Aug 18, 2012 at 07:07:46PM +, Blue Swirl wrote: > On Sat, Aug 18, 2012 at 4:16 PM, Alon Levy wrote: > > On Sat, Aug 18, 2012 at 02:31:32PM +, Blue Swirl wrote: > >> On Fri, Aug 17, 2012 at 3:39 PM, Alon Levy wrote: > >> > Revision bumped to 4 for new IO support, enabled for spice-

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
> On 08/20/12 10:00, Alon Levy wrote: > >> Hi, > >> > > +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC +#define > > QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0 > > Just delete this and use > defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC). > >>> > >>> So you are telling me to undo a change th

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Gerd Hoffmann
On 08/20/12 10:00, Alon Levy wrote: >> Hi, >> > +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC +#define > QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0 Just delete this and use defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC). >>> >>> So you are telling me to undo a change that Gerd asked for -

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
> > Hi, > > > > >>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC > > >>> +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0 > > >> > > >> Just delete this and use > > >> defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC). > > > > > > So you are telling me to undo a change that Gerd asked for - > > > could > > > you

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
> Hi, > > >>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC > >>> +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0 > >> > >> Just delete this and use > >> defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC). > > > > So you are telling me to undo a change that Gerd asked for - could > > you > > please at least debat

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-19 Thread Gerd Hoffmann
Hi, >>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC >>> +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0 >> >> Just delete this and use defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC). > > So you are telling me to undo a change that Gerd asked for - could you > please at least debate about the merits of bot

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-18 Thread Blue Swirl
On Sat, Aug 18, 2012 at 4:16 PM, Alon Levy wrote: > On Sat, Aug 18, 2012 at 02:31:32PM +, Blue Swirl wrote: >> On Fri, Aug 17, 2012 at 3:39 PM, Alon Levy wrote: >> > Revision bumped to 4 for new IO support, enabled for spice-server >= >> > 0.11.1. New io enabled iff spice-server >= 0.11.1 &&

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-18 Thread Alon Levy
On Sat, Aug 18, 2012 at 02:31:32PM +, Blue Swirl wrote: > On Fri, Aug 17, 2012 at 3:39 PM, Alon Levy wrote: > > Revision bumped to 4 for new IO support, enabled for spice-server >= > > 0.11.1. New io enabled iff spice-server >= 0.11.1 && spice-protocol >= > > 0.12.0. > > > > On migration reiss

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-18 Thread Blue Swirl
On Fri, Aug 17, 2012 at 3:39 PM, Alon Levy wrote: > Revision bumped to 4 for new IO support, enabled for spice-server >= > 0.11.1. New io enabled iff spice-server >= 0.11.1 && spice-protocol >= > 0.12.0. > > On migration reissue spice_qxl_monitors_config_async. > > RHBZ: 770842 > > Signed-off-by:

[Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-17 Thread Alon Levy
Revision bumped to 4 for new IO support, enabled for spice-server >= 0.11.1. New io enabled iff spice-server >= 0.11.1 && spice-protocol >= 0.12.0. On migration reissue spice_qxl_monitors_config_async. RHBZ: 770842 Signed-off-by: Alon Levy --- Fixed another defined I missed. This time used grep