Re: [Qemu-devel] [PATCH v7 08/16] sdhci: add basic Spec v1 capabilities

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 16:45, Philippe Mathieu-Daudé wrote: >> s->version = (SDHC_HCVER_VENDOR << 8) | (s->spec_version - 1); >> >> +capab = sdhci_init_capareg(s, errp); >> +if (errp && *errp) { > Paolo said this is wrong, I'll resping using UINT64_MAX as error and > checking "if (capab == UI

Re: [Qemu-devel] [PATCH v7 08/16] sdhci: add basic Spec v1 capabilities

2018-01-18 Thread Philippe Mathieu-Daudé
On 01/18/2018 09:32 AM, Philippe Mathieu-Daudé wrote: > (Note than Spec v2 is supported by default) > > we emit a warning for missing capabilities bits. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sdhci-internal.h | 24 ++- > include/hw/sd/sdhci.h | 11 + >

[Qemu-devel] [PATCH v7 08/16] sdhci: add basic Spec v1 capabilities

2018-01-18 Thread Philippe Mathieu-Daudé
(Note than Spec v2 is supported by default) we emit a warning for missing capabilities bits. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 24 ++- include/hw/sd/sdhci.h | 11 + hw/sd/sdhci.c | 63 ++--