Re: [Qemu-devel] [PATCH v7 07/32] target-arm: extend async excp masking

2014-10-27 Thread Greg Bellows
On 27 October 2014 06:57, Peter Maydell wrote: > On 26 October 2014 22:30, Peter Maydell wrote: > > In fact, since all of the "exception is not taken" cases are for > > "we are in secure EL3 and the exception is not being routed to > > secure EL3" you could just make all those entries read "1" a

Re: [Qemu-devel] [PATCH v7 07/32] target-arm: extend async excp masking

2014-10-27 Thread Peter Maydell
On 26 October 2014 22:30, Peter Maydell wrote: > In fact, since all of the "exception is not taken" cases are for > "we are in secure EL3 and the exception is not being routed to > secure EL3" you could just make all those entries read "1" and > rely on the "target_el < current_el" check. That doe

Re: [Qemu-devel] [PATCH v7 07/32] target-arm: extend async excp masking

2014-10-26 Thread Peter Maydell
On 24 October 2014 23:43, Greg Bellows wrote: > Based on our discussion, I looked into a table lookup approach to replace > the arm_phys_excp_target_el() as we discussed. I have something working but > still need to verify it is 100% correct. Before I went much further, I > thought I'd share my

Re: [Qemu-devel] [PATCH v7 07/32] target-arm: extend async excp masking

2014-10-24 Thread Greg Bellows
Hi Peter, Based on our discussion, I looked into a table lookup approach to replace the arm_phys_excp_target_el() as we discussed. I have something working but still need to verify it is 100% correct. Before I went much further, I thought I'd share my findings. In order to do the table in a way

Re: [Qemu-devel] [PATCH v7 07/32] target-arm: extend async excp masking

2014-10-24 Thread Peter Maydell
On 21 October 2014 17:55, Greg Bellows wrote: > From: Fabian Aggeler > > This patch extends arm_excp_unmasked() according to ARM ARMv7 and > ARM ARMv8 (all EL running in AArch32) and adds comments. > > If EL3 is using AArch64 IRQ/FIQ masking is ignored in > all exception levels other than EL3 if

[Qemu-devel] [PATCH v7 07/32] target-arm: extend async excp masking

2014-10-21 Thread Greg Bellows
From: Fabian Aggeler This patch extends arm_excp_unmasked() according to ARM ARMv7 and ARM ARMv8 (all EL running in AArch32) and adds comments. If EL3 is using AArch64 IRQ/FIQ masking is ignored in all exception levels other than EL3 if SCR.{FIQ|IRQ} is set to 1 (routed to EL3). Signed-off-by: