Re: [Qemu-devel] [PATCH v7 04/15] Makefile: Rules for docker testing

2016-06-01 Thread Fam Zheng
On Wed, 06/01 10:18, Paolo Bonzini wrote: > > > On 01/06/2016 06:25, Fam Zheng wrote: > > +# Use a global constant ccache directory to speed up repetitive builds > > +DOCKER_CCACHE_DIR := /var/tmp/qemu-docker-ccache > > Same here, use $HOME/.cache/qemu-docker-ccache instead. Do you need a > mkd

Re: [Qemu-devel] [PATCH v7 04/15] Makefile: Rules for docker testing

2016-06-01 Thread Paolo Bonzini
On 01/06/2016 06:25, Fam Zheng wrote: > +# Use a global constant ccache directory to speed up repetitive builds > +DOCKER_CCACHE_DIR := /var/tmp/qemu-docker-ccache Same here, use $HOME/.cache/qemu-docker-ccache instead. Do you need a mkdir -p? Paolo

Re: [Qemu-devel] [PATCH v7 04/15] Makefile: Rules for docker testing

2016-06-01 Thread Paolo Bonzini
On 01/06/2016 06:25, Fam Zheng wrote: > +CUR_TIME := $(shell date +%Y-%m-%d-%H.%M.%S.) > +# Makes the definition constant after the first expansion > +DOCKER_SRC_COPY = $(eval DOCKER_SRC_COPY := > /tmp/docker-src.$(CUR_TIME))$(DOCKER_SRC_COPY) > + > +$(DOCKER_SRC_COPY): > + @mkdir $@ > +

[Qemu-devel] [PATCH v7 04/15] Makefile: Rules for docker testing

2016-05-31 Thread Fam Zheng
This adds a group of make targets to run docker tests, all are available in source tree without running ./configure. The usage is shown with "make docker". Besides the fixed ones, dynamic targets for building each image and running each test in each image are generated automatically by make, scan