Re: [Qemu-devel] [PATCH v7 03/14] qapi: Drop redundant alternate-good test

2015-10-13 Thread Eric Blake
On 10/13/2015 02:12 AM, Markus Armbruster wrote: >> Hmm, any test that has an empty .err and non-empty .out, but which does >> not also have an TODO/FIXME stating that it is a bug, is worth checking. >> So first, here's the list of non-empty .out files: >> > > Actually, the point isn't to move

Re: [Qemu-devel] [PATCH v7 03/14] qapi: Drop redundant alternate-good test

2015-10-13 Thread Markus Armbruster
Eric Blake writes: > On 10/07/2015 10:15 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> The alternate-good.json test was already covered by >>> qapi-schema-test.json. As future commits will be tweaking >>> how alternates are laid out, removing the duplicate test now >>> reduces chur

Re: [Qemu-devel] [PATCH v7 03/14] qapi: Drop redundant alternate-good test

2015-10-07 Thread Eric Blake
On 10/07/2015 10:15 AM, Markus Armbruster wrote: > Eric Blake writes: > >> The alternate-good.json test was already covered by >> qapi-schema-test.json. As future commits will be tweaking >> how alternates are laid out, removing the duplicate test now >> reduces churn. > > Do we have more posit

Re: [Qemu-devel] [PATCH v7 03/14] qapi: Drop redundant alternate-good test

2015-10-07 Thread Markus Armbruster
Eric Blake writes: > The alternate-good.json test was already covered by > qapi-schema-test.json. As future commits will be tweaking > how alternates are laid out, removing the duplicate test now > reduces churn. Do we have more positive tests? They should probably all live in qapi-schema-test

[Qemu-devel] [PATCH v7 03/14] qapi: Drop redundant alternate-good test

2015-10-03 Thread Eric Blake
The alternate-good.json test was already covered by qapi-schema-test.json. As future commits will be tweaking how alternates are laid out, removing the duplicate test now reduces churn. Signed-off-by: Eric Blake --- v7: new patch --- tests/Makefile| 1 - tests/qapi-sch