Re: [Qemu-devel] [PATCH v7 02/17] vfio: introduce vfio_get_vaddr()

2017-02-09 Thread Peter Xu
On Fri, Feb 10, 2017 at 12:12:22PM +1100, David Gibson wrote: > On Tue, Feb 07, 2017 at 04:28:04PM +0800, Peter Xu wrote: > > A cleanup for vfio_iommu_map_notify(). Now we will fetch vaddr even if > > the operation is unmap, but it won't hurt much. > > > > One thing to mention is that we need the

Re: [Qemu-devel] [PATCH v7 02/17] vfio: introduce vfio_get_vaddr()

2017-02-09 Thread David Gibson
On Tue, Feb 07, 2017 at 04:28:04PM +0800, Peter Xu wrote: > A cleanup for vfio_iommu_map_notify(). Now we will fetch vaddr even if > the operation is unmap, but it won't hurt much. > > One thing to mention is that we need the RCU read lock to protect the > whole translation and map/unmap procedure

[Qemu-devel] [PATCH v7 02/17] vfio: introduce vfio_get_vaddr()

2017-02-07 Thread Peter Xu
A cleanup for vfio_iommu_map_notify(). Now we will fetch vaddr even if the operation is unmap, but it won't hurt much. One thing to mention is that we need the RCU read lock to protect the whole translation and map/unmap procedure. Acked-by: Alex Williamson Reviewed-by: David Gibson Signed-off-