Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-18 Thread Don Slutz
On 06/17/15 14:58, Michael S. Tsirkin wrote: > On Wed, Jun 17, 2015 at 01:34:33PM -0400, Don Slutz wrote: >> On 06/17/15 13:25, Paolo Bonzini wrote: >>> >>> >>> On 17/06/2015 19:14, Paolo Bonzini wrote: On 17/06/2015 19:03, Don Slutz wrote: > On 06/17/15 12:29, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-18 Thread Michael S. Tsirkin
On Thu, Jun 18, 2015 at 10:33:00AM +0200, Paolo Bonzini wrote: > > > On 18/06/2015 09:58, Michael S. Tsirkin wrote: > > > If I am reading this correctly, I should add > > > > > > Acked-by: Paolo Bonzini > > > > > > to these 4 patches. > > > > > > Since I have never sent a pull request to QEMU

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-18 Thread Paolo Bonzini
On 18/06/2015 00:26, Don Slutz wrote: > > The following changes since commit > f754c3c9cce3c4789733d9068394be4256dfe6a8: > > Merge remote-tracking branch > 'remotes/agraf/tags/signed-s390-for-upstream' into staging > (2015-06-17 12:43:26 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-18 Thread Paolo Bonzini
On 18/06/2015 09:58, Michael S. Tsirkin wrote: > > If I am reading this correctly, I should add > > > > Acked-by: Paolo Bonzini > > > > to these 4 patches. > > > > Since I have never sent a pull request to QEMU before here is what I > > think should be in it: > > I'd like to see a version wi

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-18 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 06:26:06PM -0400, Don Slutz wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/17/15 09:44, Paolo Bonzini wrote: > > > > On 12/06/2015 16:05, Don Slutz wrote: > >> Changes v6 to v7: > ... > > Looks good, feel free to send out patches 1+2+3+9 in a pull req

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-18 Thread Gerd Hoffmann
Hi, > we enable this thing by default (why do we?) Historical reasons :( At least we recently got an option to turn it off (-machine $name,vmport=off) cheers, Gerd

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Don Slutz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/17/15 09:44, Paolo Bonzini wrote: > > On 12/06/2015 16:05, Don Slutz wrote: >> Changes v6 to v7: ... > Looks good, feel free to send out patches 1+2+3+9 in a pull request if > you want. If I am reading this correctly, I should add Acked-by: Pa

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 09:24:44PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 21:22, Michael S. Tsirkin wrote: > > > Does it make sense to have an ISA device that has no ports or MMIO > > > regions? It's a bit of hack modeling-wise, but sure it works. > > > > I didn't write this code :) >

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 21:22, Michael S. Tsirkin wrote: > > Does it make sense to have an ISA device that has no ports or MMIO > > regions? It's a bit of hack modeling-wise, but sure it works. > > I didn't write this code :) Well, you did: :) >>> +vmport_rpc = isa_try_create(isa_bus, "vmport_r

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 09:15:56PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 20:43, Michael S. Tsirkin wrote: > > It seems pretty obvious: > > > > +vmport_rpc = isa_try_create(isa_bus, "vmport_rpc"); > > +if (vmport_rpc) { > > +qdev_init_nofail(DEVICE(vmport_rpc

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 20:43, Michael S. Tsirkin wrote: > It seems pretty obvious: > > +vmport_rpc = isa_try_create(isa_bus, "vmport_rpc"); > +if (vmport_rpc) { > +qdev_init_nofail(DEVICE(vmport_rpc)); > +} > > > Don't do this. Let user specify the device using -devi

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 01:34:33PM -0400, Don Slutz wrote: > On 06/17/15 13:25, Paolo Bonzini wrote: > > > > > > On 17/06/2015 19:14, Paolo Bonzini wrote: > >> > >> > >> On 17/06/2015 19:03, Don Slutz wrote: > >>> On 06/17/15 12:29, Michael S. Tsirkin wrote: > On Wed, Jun 17, 2015 at 06:17:1

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 07:14:24PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 19:03, Don Slutz wrote: > > On 06/17/15 12:29, Michael S. Tsirkin wrote: > >> On Wed, Jun 17, 2015 at 06:17:19PM +0200, Paolo Bonzini wrote: > >>> > >>> > >>> On 17/06/2015 16:29, Michael S. Tsirkin wrote: > O

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 06:48:40PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 18:29, Michael S. Tsirkin wrote: > > On Wed, Jun 17, 2015 at 06:17:19PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 17/06/2015 16:29, Michael S. Tsirkin wrote: > >>> On Wed, Jun 17, 2015 at 04:27:13PM +0200, Paol

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 01:03:00PM -0400, Don Slutz wrote: > On 06/17/15 12:29, Michael S. Tsirkin wrote: > > On Wed, Jun 17, 2015 at 06:17:19PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 17/06/2015 16:29, Michael S. Tsirkin wrote: > >>> On Wed, Jun 17, 2015 at 04:27:13PM +0200, Paolo Bonzini wr

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Don Slutz
On 06/17/15 13:25, Paolo Bonzini wrote: > > > On 17/06/2015 19:14, Paolo Bonzini wrote: >> >> >> On 17/06/2015 19:03, Don Slutz wrote: >>> On 06/17/15 12:29, Michael S. Tsirkin wrote: On Wed, Jun 17, 2015 at 06:17:19PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 16:29, Michae

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 19:14, Paolo Bonzini wrote: > > > On 17/06/2015 19:03, Don Slutz wrote: >> On 06/17/15 12:29, Michael S. Tsirkin wrote: >>> On Wed, Jun 17, 2015 at 06:17:19PM +0200, Paolo Bonzini wrote: On 17/06/2015 16:29, Michael S. Tsirkin wrote: > On Wed, Jun 17, 2015 at 04

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 19:03, Don Slutz wrote: > On 06/17/15 12:29, Michael S. Tsirkin wrote: >> On Wed, Jun 17, 2015 at 06:17:19PM +0200, Paolo Bonzini wrote: >>> >>> >>> On 17/06/2015 16:29, Michael S. Tsirkin wrote: On Wed, Jun 17, 2015 at 04:27:13PM +0200, Paolo Bonzini wrote: > > > O

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Don Slutz
On 06/17/15 12:29, Michael S. Tsirkin wrote: > On Wed, Jun 17, 2015 at 06:17:19PM +0200, Paolo Bonzini wrote: >> >> >> On 17/06/2015 16:29, Michael S. Tsirkin wrote: >>> On Wed, Jun 17, 2015 at 04:27:13PM +0200, Paolo Bonzini wrote: On 17/06/2015 16:18, Michael S. Tsirkin wrote:

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 18:29, Michael S. Tsirkin wrote: > On Wed, Jun 17, 2015 at 06:17:19PM +0200, Paolo Bonzini wrote: >> >> >> On 17/06/2015 16:29, Michael S. Tsirkin wrote: >>> On Wed, Jun 17, 2015 at 04:27:13PM +0200, Paolo Bonzini wrote: On 17/06/2015 16:18, Michael S. Tsirkin wrote:

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 06:17:19PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 16:29, Michael S. Tsirkin wrote: > > On Wed, Jun 17, 2015 at 04:27:13PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 17/06/2015 16:18, Michael S. Tsirkin wrote: > > Yes, that's what was done for parallel and p

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 16:29, Michael S. Tsirkin wrote: > On Wed, Jun 17, 2015 at 04:27:13PM +0200, Paolo Bonzini wrote: >> >> >> On 17/06/2015 16:18, Michael S. Tsirkin wrote: > Yes, that's what was done for parallel and pcspk as well. There's no > infrastructure to avoid it. > > Paolo >

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 16:18, Michael S. Tsirkin wrote: >> > Yes, that's what was done for parallel and pcspk as well. There's no >> > infrastructure to avoid it. >> > >> > Paolo > How do you mean? We have multiple ways to keep devices > compatible with old versions. > Set a new property to skip the ext

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 04:27:13PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 16:18, Michael S. Tsirkin wrote: > >> > Yes, that's what was done for parallel and pcspk as well. There's no > >> > infrastructure to avoid it. > >> > > >> > Paolo > > How do you mean? We have multiple ways to ke

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Michael S. Tsirkin
On Fri, Jun 12, 2015 at 10:05:47AM -0400, Don Slutz wrote: > Changes v6 to v7: > Rebase to master > > Fixed a bug caused by commit c3c1bb99d1c11978d9ce94d1bdcf0705378c1459 now > patch #1 > Added patch #2 to switch to using trace in vm,port.c. > > Delay call on g_strndup till after key l

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 04:13:52PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 16:11, Michael S. Tsirkin wrote: > > On Fri, Jun 12, 2015 at 10:05:47AM -0400, Don Slutz wrote: > >> Changes v6 to v7: > >> Rebase to master > >> > >> Fixed a bug caused by commit c3c1bb99d1c11978d9ce94d1bdcf07

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 16:11, Michael S. Tsirkin wrote: > On Fri, Jun 12, 2015 at 10:05:47AM -0400, Don Slutz wrote: >> Changes v6 to v7: >> Rebase to master >> >> Fixed a bug caused by commit c3c1bb99d1c11978d9ce94d1bdcf0705378c1459 now >> patch #1 > >> Added patch #2 to switch to using trace in

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Paolo Bonzini
On 12/06/2015 16:05, Don Slutz wrote: > Changes v6 to v7: > Rebase to master > > Fixed a bug caused by commit c3c1bb99d1c11978d9ce94d1bdcf0705378c1459 now > patch #1 > > Added patch #2 to switch to using trace in vm,port.c. > > Delay call on g_strndup till after key length check. > >

[Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-12 Thread Don Slutz
Changes v6 to v7: Rebase to master Fixed a bug caused by commit c3c1bb99d1c11978d9ce94d1bdcf0705378c1459 now patch #1 Added patch #2 to switch to using trace in vm,port.c. Delay call on g_strndup till after key length check. Switched e-mail address in MAINTAINERS. Eric Blake W