Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 02:42:40PM +0800, Peter Xu wrote: > > I think the answer is no - it doesn't matter; by telling the hypervisor > > the page is 'free' the kernel gives freedom to the hypervisor to > > discard the page contents. > > Yeh it seems so. Well not exactly. I replied to parent wit

Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-06-05 Thread Michael S. Tsirkin
On Fri, Jun 01, 2018 at 04:33:29PM +0100, Dr. David Alan Gilbert wrote: > I think the answer is no - it doesn't matter; by telling the hypervisor > the page is 'free' the kernel gives freedom to the hypervisor to > discard the page contents. I'd like to call attention to this since it's easy to ge

Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-06-04 Thread Peter Xu
On Fri, Jun 01, 2018 at 04:33:29PM +0100, Dr. David Alan Gilbert wrote: [...] > > > > Meanwhile, this reminds me about a more funny idea: whether we can > > > > just avoid sending the zero pages directly from QEMU's perspective. > > > > In other words, can we just do nothing if save_zero_page() d

Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-06-01 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Jun 01, 2018 at 03:21:54PM +0800, Wei Wang wrote: > > On 06/01/2018 12:58 PM, Peter Xu wrote: > > > On Tue, Apr 24, 2018 at 02:13:43PM +0800, Wei Wang wrote: > > > > This is the deivce part implementation to add a new feature, > > > > VIRTIO_BALLOON_F

Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-06-01 Thread Wei Wang
On 06/01/2018 06:02 PM, Peter Xu wrote: On Fri, Jun 01, 2018 at 03:29:45PM +0800, Wei Wang wrote: On 06/01/2018 01:07 PM, Peter Xu wrote: On Fri, Jun 01, 2018 at 12:58:24PM +0800, Peter Xu wrote: On Tue, Apr 24, 2018 at 02:13:43PM +0800, Wei Wang wrote: This is the deivce part implementation

Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-06-01 Thread Peter Xu
On Fri, Jun 01, 2018 at 03:21:54PM +0800, Wei Wang wrote: > On 06/01/2018 12:58 PM, Peter Xu wrote: > > On Tue, Apr 24, 2018 at 02:13:43PM +0800, Wei Wang wrote: > > > This is the deivce part implementation to add a new feature, > > > VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. Th

Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-06-01 Thread Peter Xu
On Fri, Jun 01, 2018 at 03:29:45PM +0800, Wei Wang wrote: > On 06/01/2018 01:07 PM, Peter Xu wrote: > > On Fri, Jun 01, 2018 at 12:58:24PM +0800, Peter Xu wrote: > > > On Tue, Apr 24, 2018 at 02:13:43PM +0800, Wei Wang wrote: > > > > This is the deivce part implementation to add a new feature, > >

Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-06-01 Thread Wei Wang
On 06/01/2018 01:07 PM, Peter Xu wrote: On Fri, Jun 01, 2018 at 12:58:24PM +0800, Peter Xu wrote: On Tue, Apr 24, 2018 at 02:13:43PM +0800, Wei Wang wrote: This is the deivce part implementation to add a new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device recei

Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-06-01 Thread Wei Wang
On 06/01/2018 12:58 PM, Peter Xu wrote: On Tue, Apr 24, 2018 at 02:13:43PM +0800, Wei Wang wrote: This is the deivce part implementation to add a new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device receives the guest free page hints from the driver and clears th

Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-05-31 Thread Peter Xu
On Fri, Jun 01, 2018 at 12:58:24PM +0800, Peter Xu wrote: > On Tue, Apr 24, 2018 at 02:13:43PM +0800, Wei Wang wrote: > > This is the deivce part implementation to add a new feature, > > VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device > > receives the guest free page hints

Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-05-31 Thread Peter Xu
On Tue, Apr 24, 2018 at 02:13:43PM +0800, Wei Wang wrote: > This is the deivce part implementation to add a new feature, > VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device > receives the guest free page hints from the driver and clears the > corresponding bits in the dirty b

Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-05-29 Thread Michael S. Tsirkin
On Tue, May 29, 2018 at 11:00:21PM +0800, Hailiang Zhang wrote: > On 2018/4/24 14:13, Wei Wang wrote: > > This is the deivce part implementation to add a new feature, > > VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device > > receives the guest free page hints from the driver

Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-05-29 Thread Hailiang Zhang
On 2018/4/24 14:13, Wei Wang wrote: This is the deivce part implementation to add a new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device receives the guest free page hints from the driver and clears the corresponding bits in the dirty bitmap, so that those free pa

Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-05-13 Thread Wei Wang
On 04/24/2018 02:13 PM, Wei Wang wrote: This is the deivce part implementation to add a new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device receives the guest free page hints from the driver and clears the corresponding bits in the dirty bitmap, so that those fre

Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-04-23 Thread Wei Wang
On 04/24/2018 02:13 PM, Wei Wang wrote: This is the deivce part implementation to add a new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device receives the guest free page hints from the driver and clears the corresponding bits in the dirty bitmap, so that those fre

[Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-04-23 Thread Wei Wang
This is the deivce part implementation to add a new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device receives the guest free page hints from the driver and clears the corresponding bits in the dirty bitmap, so that those free pages are not transferred by the migrati