Re: [Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

2017-02-15 Thread Ben Warren
> On Feb 15, 2017, at 7:24 AM, Laszlo Ersek wrote: > > On 02/15/17 13:19, Igor Mammedov wrote: >> On Tue, 14 Feb 2017 22:15:46 -0800 >> b...@skyportsystems.com wrote: >> >>> From: Ben Warren >>> >>> This implements the VM Generation ID feature by passing a 128-bit >>> GUID to the guest via a

Re: [Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

2017-02-15 Thread Ben Warren
> On Feb 15, 2017, at 8:40 AM, Michael S. Tsirkin wrote: > > On Wed, Feb 15, 2017 at 05:07:57PM +0100, Igor Mammedov wrote: >>> Those improvements can be added later, IMO -- but please do work out >>> with Igor whether he really wants a v7 for those. >> since it's minor fixes not influencing oth

Re: [Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

2017-02-15 Thread Ben Warren
Hi Igor. Thanks for the review! > On Feb 15, 2017, at 4:19 AM, Igor Mammedov wrote: > > On Tue, 14 Feb 2017 22:15:46 -0800 > b...@skyportsystems.com wrote: > >> From: Ben Warren >> >> This implements the VM Generation ID feature by passing a 128-bit >> GUID t

Re: [Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

2017-02-15 Thread Michael S. Tsirkin
On Wed, Feb 15, 2017 at 05:07:57PM +0100, Igor Mammedov wrote: > > Those improvements can be added later, IMO -- but please do work out > > with Igor whether he really wants a v7 for those. > since it's minor fixes not influencing other patches within series > there is not need to repost whole seri

Re: [Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

2017-02-15 Thread Igor Mammedov
On Wed, 15 Feb 2017 16:24:52 +0100 Laszlo Ersek wrote: > On 02/15/17 13:19, Igor Mammedov wrote: > > On Tue, 14 Feb 2017 22:15:46 -0800 > > b...@skyportsystems.com wrote: > > > >> From: Ben Warren > >> > >> This implements the VM Generation ID feature by passing a 128-bit > >> GUID to the gue

Re: [Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

2017-02-15 Thread Laszlo Ersek
On 02/15/17 13:19, Igor Mammedov wrote: > On Tue, 14 Feb 2017 22:15:46 -0800 > b...@skyportsystems.com wrote: > >> From: Ben Warren >> >> This implements the VM Generation ID feature by passing a 128-bit >> GUID to the guest via a fw_cfg blob. >> Any time the GUID changes, an ACPI notify event is

Re: [Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

2017-02-15 Thread Igor Mammedov
On Tue, 14 Feb 2017 22:15:46 -0800 b...@skyportsystems.com wrote: > From: Ben Warren > > This implements the VM Generation ID feature by passing a 128-bit > GUID to the guest via a fw_cfg blob. > Any time the GUID changes, an ACPI notify event is sent to the guest > > The user interface is a si

[Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

2017-02-14 Thread ben
From: Ben Warren This implements the VM Generation ID feature by passing a 128-bit GUID to the guest via a fw_cfg blob. Any time the GUID changes, an ACPI notify event is sent to the guest The user interface is a simple device with one parameter: - guid (string, must be "auto" or in UUID format