Re: [Qemu-devel] [PATCH v6 17/27] qapi: add 'if' to implicit struct members

2018-12-06 Thread Markus Armbruster
Marc-André Lureau writes: > Generated code is not changed by this patch, but with "qapi: add #if > conditions to generated code" patch. My suggestion on PATCH 13's commit message applies. > Signed-off-by: Marc-André Lureau Other than that, Reviewed-by: Markus Armbruster

[Qemu-devel] [PATCH v6 17/27] qapi: add 'if' to implicit struct members

2018-07-06 Thread Marc-André Lureau
Generated code is not changed by this patch, but with "qapi: add #if conditions to generated code" patch. Signed-off-by: Marc-André Lureau --- scripts/qapi/common.py | 14 +++--- tests/qapi-schema/qapi-schema-test.json | 12 +--- tests/qapi-schema/qapi-schema-tes