Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Fam Zheng
On Wed, 09/11 15:41, Paolo Bonzini wrote: > Il 11/09/2013 15:34, Fam Zheng ha scritto: > > Makefile.target includes rule.mak and unnested common-obj-y, then prefix > > them with '../', this will ignore object specific QEMU_CFLAGS in subdir > > Makefile.objs: > > > > $(obj)/curl.o: QEMU_CFLAGS

Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Fam Zheng
On Wed, 09/11 15:59, Daniel P. Berrange wrote: > On Wed, Sep 11, 2013 at 09:34:01PM +0800, Fam Zheng wrote: > > Makefile.target includes rule.mak and unnested common-obj-y, then prefix > > them with '../', this will ignore object specific QEMU_CFLAGS in subdir > > Makefile.objs: > > > > $(obj)

Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Fam Zheng
On Wed, 09/11 15:59, Daniel P. Berrange wrote: > On Wed, Sep 11, 2013 at 09:34:01PM +0800, Fam Zheng wrote: > > Makefile.target includes rule.mak and unnested common-obj-y, then prefix > > them with '../', this will ignore object specific QEMU_CFLAGS in subdir > > Makefile.objs: > > > > $(obj)

Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 18:38, Peter Maydell ha scritto: > On 11 September 2013 14:34, Fam Zheng wrote: >> Makefile.target includes rule.mak and unnested common-obj-y, then prefix >> them with '../', this will ignore object specific QEMU_CFLAGS in subdir >> Makefile.objs: >> >> $(obj)/curl.o: QEMU_CFLAG

Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Peter Maydell
On 11 September 2013 17:40, Paolo Bonzini wrote: > Il 11/09/2013 18:38, Peter Maydell ha scritto: >> I think the right fix for this is just to delete that line >> from ui/Makefile.objs, because we have a generic >> rule that says "you can build foo.o from foo.m with >> an objective-C compiler". Th

Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Peter Maydell
On 11 September 2013 14:34, Fam Zheng wrote: > Makefile.target includes rule.mak and unnested common-obj-y, then prefix > them with '../', this will ignore object specific QEMU_CFLAGS in subdir > Makefile.objs: > > $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) > > Because $(obj) here is './bloc

Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 09:34:01PM +0800, Fam Zheng wrote: > Makefile.target includes rule.mak and unnested common-obj-y, then prefix > them with '../', this will ignore object specific QEMU_CFLAGS in subdir > Makefile.objs: > > $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) > > Because $(obj)

[Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Fam Zheng
Makefile.target includes rule.mak and unnested common-obj-y, then prefix them with '../', this will ignore object specific QEMU_CFLAGS in subdir Makefile.objs: $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) Because $(obj) here is './block', instead of '../block'. This doesn't hurt compiling bec

Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 15:34, Fam Zheng ha scritto: > Makefile.target includes rule.mak and unnested common-obj-y, then prefix > them with '../', this will ignore object specific QEMU_CFLAGS in subdir > Makefile.objs: > > $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) > > Because $(obj) here is './block