Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-16 Thread Eric Blake
[meta-comment] On 02/16/2017 05:10 AM, Igor Mammedov wrote: > On Wed, 15 Feb 2017 11:19:44 -0800 > Ben Warren wrote: > >>> On Feb 15, 2017, at 11:14 AM, Ben Warren wrote: ... > This is similar to the existing 'add pointer' functionality, but > instead 13 levels of quot

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-16 Thread Igor Mammedov
On Wed, 15 Feb 2017 11:19:44 -0800 Ben Warren wrote: > > On Feb 15, 2017, at 11:14 AM, Ben Warren wrote: > > > >> > >> On Feb 15, 2017, at 10:24 AM, Igor Mammedov >> > wrote: > >> > >> On Wed, 15 Feb 2017 20:04:40 +0200 > >> "Michael S. Tsirkin" mailto:m...@redh

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-16 Thread Laszlo Ersek
On 02/16/17 09:25, Igor Mammedov wrote: > On Wed, 15 Feb 2017 21:34:45 +0200 > "Michael S. Tsirkin" wrote: > >> On Wed, Feb 15, 2017 at 07:24:36PM +0100, Igor Mammedov wrote: As long as all users pass in 0 though there's a real possibility guests will implement this incorrectly. >>> W

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-16 Thread Igor Mammedov
On Wed, 15 Feb 2017 21:34:45 +0200 "Michael S. Tsirkin" wrote: > On Wed, Feb 15, 2017 at 07:24:36PM +0100, Igor Mammedov wrote: > > > As long as all users pass in 0 though there's a real possibility guests > > > will implement this incorrectly. > > We are here to ensure that at least Seabios (I

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Michael S. Tsirkin
On Wed, Feb 15, 2017 at 10:44:05AM -0800, Ben Warren wrote: > > On Feb 15, 2017, at 10:35 AM, Igor Mammedov wrote: > > On Wed, 15 Feb 2017 10:14:55 -0800 > Ben Warren wrote: > > > On Feb 15, 2017, at 10:06 AM, Michael S. Tsirkin > wrote: > > O

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Michael S. Tsirkin
On Wed, Feb 15, 2017 at 07:24:36PM +0100, Igor Mammedov wrote: > > As long as all users pass in 0 though there's a real possibility guests > > will implement this incorrectly. > We are here to ensure that at least Seabios (I'll review it) > and OVMF (Laszlo would take care of it I suppose) do it ri

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Ben Warren
> On Feb 15, 2017, at 11:14 AM, Ben Warren wrote: > >> >> On Feb 15, 2017, at 10:24 AM, Igor Mammedov > > wrote: >> >> On Wed, 15 Feb 2017 20:04:40 +0200 >> "Michael S. Tsirkin" mailto:m...@redhat.com>> wrote: >> >>> On Wed, Feb 15, 2017 at 06:43:09PM +0100, Igor M

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Ben Warren
> On Feb 15, 2017, at 10:24 AM, Igor Mammedov wrote: > > On Wed, 15 Feb 2017 20:04:40 +0200 > "Michael S. Tsirkin" mailto:m...@redhat.com>> wrote: > >> On Wed, Feb 15, 2017 at 06:43:09PM +0100, Igor Mammedov wrote: >>> On Wed, 15 Feb 2017 18:39:06 +0200 >>> "Michael S. Tsirkin" wrote: >>> >>>

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Ben Warren
> On Feb 15, 2017, at 10:35 AM, Igor Mammedov wrote: > > On Wed, 15 Feb 2017 10:14:55 -0800 > Ben Warren mailto:b...@skyportsystems.com>> wrote: > >>> On Feb 15, 2017, at 10:06 AM, Michael S. Tsirkin wrote: >>> >>> On Wed, Feb 15, 2017 at 09:54:08AM -0800, Ben Warren wrote: On

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Igor Mammedov
On Wed, 15 Feb 2017 10:14:55 -0800 Ben Warren wrote: > > On Feb 15, 2017, at 10:06 AM, Michael S. Tsirkin wrote: > > > > On Wed, Feb 15, 2017 at 09:54:08AM -0800, Ben Warren wrote: > >> > >>On Feb 15, 2017, at 9:43 AM, Igor Mammedov wrote: > >> > >>On Wed, 15 Feb 2017 18:39:06 +020

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Igor Mammedov
On Wed, 15 Feb 2017 20:04:40 +0200 "Michael S. Tsirkin" wrote: > On Wed, Feb 15, 2017 at 06:43:09PM +0100, Igor Mammedov wrote: > > On Wed, 15 Feb 2017 18:39:06 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Feb 15, 2017 at 04:56:02PM +0100, Igor Mammedov wrote: > > > > On Wed, 15

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Ben Warren
> On Feb 15, 2017, at 10:06 AM, Michael S. Tsirkin wrote: > > On Wed, Feb 15, 2017 at 09:54:08AM -0800, Ben Warren wrote: >> >>On Feb 15, 2017, at 9:43 AM, Igor Mammedov wrote: >> >>On Wed, 15 Feb 2017 18:39:06 +0200 >>"Michael S. Tsirkin" wrote: >> >> >>On Wed, Feb 15,

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Michael S. Tsirkin
On Wed, Feb 15, 2017 at 09:54:08AM -0800, Ben Warren wrote: > > On Feb 15, 2017, at 9:43 AM, Igor Mammedov wrote: > > On Wed, 15 Feb 2017 18:39:06 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Feb 15, 2017 at 04:56:02PM +0100, Igor Mammedov wrote: > > On W

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Michael S. Tsirkin
On Wed, Feb 15, 2017 at 06:43:09PM +0100, Igor Mammedov wrote: > On Wed, 15 Feb 2017 18:39:06 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Feb 15, 2017 at 04:56:02PM +0100, Igor Mammedov wrote: > > > On Wed, 15 Feb 2017 17:30:00 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On We

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Ben Warren
> On Feb 15, 2017, at 9:43 AM, Igor Mammedov wrote: > > On Wed, 15 Feb 2017 18:39:06 +0200 > "Michael S. Tsirkin" mailto:m...@redhat.com>> wrote: > >> On Wed, Feb 15, 2017 at 04:56:02PM +0100, Igor Mammedov wrote: >>> On Wed, 15 Feb 2017 17:30:00 +0200 >>> "Michael S. Tsirkin" wrote: >>>

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Igor Mammedov
On Wed, 15 Feb 2017 18:39:06 +0200 "Michael S. Tsirkin" wrote: > On Wed, Feb 15, 2017 at 04:56:02PM +0100, Igor Mammedov wrote: > > On Wed, 15 Feb 2017 17:30:00 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Feb 15, 2017 at 04:22:25PM +0100, Igor Mammedov wrote: > > > > On Wed, 15

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Laszlo Ersek
On 02/15/17 17:39, Michael S. Tsirkin wrote: > On Wed, Feb 15, 2017 at 04:56:02PM +0100, Igor Mammedov wrote: >> On Wed, 15 Feb 2017 17:30:00 +0200 >> "Michael S. Tsirkin" wrote: >> >>> On Wed, Feb 15, 2017 at 04:22:25PM +0100, Igor Mammedov wrote: On Wed, 15 Feb 2017 15:13:20 +0100 Lasz

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Michael S. Tsirkin
On Wed, Feb 15, 2017 at 04:56:02PM +0100, Igor Mammedov wrote: > On Wed, 15 Feb 2017 17:30:00 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Feb 15, 2017 at 04:22:25PM +0100, Igor Mammedov wrote: > > > On Wed, 15 Feb 2017 15:13:20 +0100 > > > Laszlo Ersek wrote: > > > > > > > Commenting un

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Igor Mammedov
On Wed, 15 Feb 2017 17:30:00 +0200 "Michael S. Tsirkin" wrote: > On Wed, Feb 15, 2017 at 04:22:25PM +0100, Igor Mammedov wrote: > > On Wed, 15 Feb 2017 15:13:20 +0100 > > Laszlo Ersek wrote: > > > > > Commenting under Igor's reply for simplicity > > > > > > On 02/15/17 11:57, Igor Mammedov w

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Michael S. Tsirkin
On Wed, Feb 15, 2017 at 04:22:25PM +0100, Igor Mammedov wrote: > On Wed, 15 Feb 2017 15:13:20 +0100 > Laszlo Ersek wrote: > > > Commenting under Igor's reply for simplicity > > > > On 02/15/17 11:57, Igor Mammedov wrote: > > > On Tue, 14 Feb 2017 22:15:43 -0800 > > > b...@skyportsystems.com wrot

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Igor Mammedov
On Wed, 15 Feb 2017 15:13:20 +0100 Laszlo Ersek wrote: > Commenting under Igor's reply for simplicity > > On 02/15/17 11:57, Igor Mammedov wrote: > > On Tue, 14 Feb 2017 22:15:43 -0800 > > b...@skyportsystems.com wrote: > > > >> From: Ben Warren > >> > >> This is similar to the existing 'add

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Laszlo Ersek
On 02/15/17 15:13, Laszlo Ersek wrote: > Commenting under Igor's reply for simplicity > > On 02/15/17 11:57, Igor Mammedov wrote: >> On Tue, 14 Feb 2017 22:15:43 -0800 >> b...@skyportsystems.com wrote: >> >>> From: Ben Warren >>> >>> This is similar to the existing 'add pointer' functionality, bu

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Laszlo Ersek
Commenting under Igor's reply for simplicity On 02/15/17 11:57, Igor Mammedov wrote: > On Tue, 14 Feb 2017 22:15:43 -0800 > b...@skyportsystems.com wrote: > >> From: Ben Warren >> >> This is similar to the existing 'add pointer' functionality, but instead >> of instructing the guest (BIOS or UEF

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Igor Mammedov
On Tue, 14 Feb 2017 22:15:43 -0800 b...@skyportsystems.com wrote: > From: Ben Warren > > This is similar to the existing 'add pointer' functionality, but instead > of instructing the guest (BIOS or UEFI) to patch memory, it instructs > the guest to write the pointer back to QEMU via a writeable

[Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-14 Thread ben
From: Ben Warren This is similar to the existing 'add pointer' functionality, but instead of instructing the guest (BIOS or UEFI) to patch memory, it instructs the guest to write the pointer back to QEMU via a writeable fw_cfg file. Signed-off-by: Ben Warren --- hw/acpi/bios-linker-loader.c