Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-26 Thread Edgar E. Iglesias
On Fri, Sep 26, 2014 at 12:43:40AM +0100, Peter Maydell wrote: > On 26 September 2014 00:31, Edgar E. Iglesias > wrote: > > On Fri, Sep 26, 2014 at 12:17:59AM +0100, Peter Maydell wrote: > >> Oh, yes, that's the trap enable bit. In that case we shouldn't > >> be using EXCP_SMC: this isn't routing

Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-25 Thread Edgar E. Iglesias
On Fri, Sep 26, 2014 at 12:43:40AM +0100, Peter Maydell wrote: > On 26 September 2014 00:31, Edgar E. Iglesias > wrote: > > On Fri, Sep 26, 2014 at 12:17:59AM +0100, Peter Maydell wrote: > >> Oh, yes, that's the trap enable bit. In that case we shouldn't > >> be using EXCP_SMC: this isn't routing

Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-25 Thread Peter Maydell
On 26 September 2014 00:31, Edgar E. Iglesias wrote: > On Fri, Sep 26, 2014 at 12:17:59AM +0100, Peter Maydell wrote: >> Oh, yes, that's the trap enable bit. In that case we shouldn't >> be using EXCP_SMC: this isn't routing the SMC exception, it's >> taking a Hyp trap exception, and in AArch32 th

Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-25 Thread Edgar E. Iglesias
On Fri, Sep 26, 2014 at 12:17:59AM +0100, Peter Maydell wrote: > On 25 September 2014 23:55, Edgar E. Iglesias > wrote: > > On Thu, Sep 25, 2014 at 07:47:16PM +0100, Peter Maydell wrote: > >> > +/* In NS EL1, HCR controlled routing to EL2 has priority over SMD. > >> > */ > >> > +if (!se

Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-25 Thread Peter Maydell
On 25 September 2014 23:55, Edgar E. Iglesias wrote: > On Thu, Sep 25, 2014 at 07:47:16PM +0100, Peter Maydell wrote: >> > +/* In NS EL1, HCR controlled routing to EL2 has priority over SMD. */ >> > +if (!secure && cur_el == 1 && (env->cp15.hcr_el2 & HCR_TSC)) { >> > +env->excepti

Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-25 Thread Edgar E. Iglesias
On Thu, Sep 25, 2014 at 07:47:16PM +0100, Peter Maydell wrote: > On 13 September 2014 05:29, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm/cpu.h | 1 + > > target-arm/helper-a64.c| 1 + > > target-arm/he

Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-25 Thread Peter Maydell
On 13 September 2014 05:29, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h | 1 + > target-arm/helper-a64.c| 1 + > target-arm/helper.c| 6 ++ > target-arm/helper.h| 1 + > target-arm/inter

Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-17 Thread Greg Bellows
Reviewed-by: Greg Bellows On 12 September 2014 21:29, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h | 1 + > target-arm/helper-a64.c| 1 + > target-arm/helper.c| 6 ++ > target-arm/helper.h

[Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h | 1 + target-arm/helper-a64.c| 1 + target-arm/helper.c| 6 ++ target-arm/helper.h| 1 + target-arm/internals.h | 6 ++ target-arm/op_helper.c | 26 +++