Re: [Qemu-devel] [PATCH v6 05/16] qapi: Test for various name collisions

2015-09-30 Thread Eric Blake
On 09/29/2015 06:33 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Expose some weaknesses in the generator: we don't always forbid >> the generation of structs that contain multiple members that map >> to the same C name. > > C or QMP name, perhaps? Lots of good advice for an improved c

Re: [Qemu-devel] [PATCH v6 05/16] qapi: Test for various name collisions

2015-09-29 Thread Markus Armbruster
Eric Blake writes: > Expose some weaknesses in the generator: we don't always forbid > the generation of structs that contain multiple members that map > to the same C name. C or QMP name, perhaps? > This has already been marked FIXME in > qapi.py in commit d90675f, but hav

[Qemu-devel] [PATCH v6 05/16] qapi: Test for various name collisions

2015-09-28 Thread Eric Blake
Expose some weaknesses in the generator: we don't always forbid the generation of structs that contain multiple members that map to the same C name. This has already been marked FIXME in qapi.py in commit d90675f, but having more tests will make sure future patches produce desired behavior. This