Re: [Qemu-devel] [PATCH v6 05/11] vhost-user: add vhost_user_gpu_set_socket()

2019-04-29 Thread Michael S. Tsirkin
On Mon, Apr 29, 2019 at 09:12:43AM +0200, Gerd Hoffmann wrote: > Hi, > > > > What questions for example? > > > > This opens up different kind of possible replies, and error handling. > > > > With current proposal and needs, the reply (or absence of reply) is > > entirely driven by the request.

Re: [Qemu-devel] [PATCH v6 05/11] vhost-user: add vhost_user_gpu_set_socket()

2019-04-29 Thread Gerd Hoffmann
Hi, > > > and complicates both sides unnecessarily. > > > > Having headers in the reply allows it to process them in generic code. > > There is a size header for the reply, so you can parse the stream > > without knowing what replay to expect. You can use the status field to > > indicate the pa

Re: [Qemu-devel] [PATCH v6 05/11] vhost-user: add vhost_user_gpu_set_socket()

2019-04-29 Thread Marc-André Lureau
Hi On Mon, Apr 29, 2019 at 9:12 AM Gerd Hoffmann wrote: > > Hi, > > > > What questions for example? > > > > This opens up different kind of possible replies, and error handling. > > > > With current proposal and needs, the reply (or absence of reply) is > > entirely driven by the request. > > >

Re: [Qemu-devel] [PATCH v6 05/11] vhost-user: add vhost_user_gpu_set_socket()

2019-04-29 Thread Gerd Hoffmann
Hi, > > What questions for example? > > This opens up different kind of possible replies, and error handling. > > With current proposal and needs, the reply (or absence of reply) is > entirely driven by the request. > > With your proposal, should all request have a reply? Yes. > which makes

Re: [Qemu-devel] [PATCH v6 05/11] vhost-user: add vhost_user_gpu_set_socket()

2019-04-26 Thread Marc-André Lureau
Hi On Fri, Apr 26, 2019 at 2:06 PM Gerd Hoffmann wrote: > > Hi, > > > > > +Wire format > > > > +=== > > > > + > > > > +Unless specified differently, numbers are in the machine native byte > > > > +order. > > > > + > > > > +A vhost-user-gpu request consists of 2 header fields and a paylo

Re: [Qemu-devel] [PATCH v6 05/11] vhost-user: add vhost_user_gpu_set_socket()

2019-04-26 Thread Gerd Hoffmann
Hi, > > > +Wire format > > > +=== > > > + > > > +Unless specified differently, numbers are in the machine native byte > > > +order. > > > + > > > +A vhost-user-gpu request consists of 2 header fields and a payload. > > > + > > > ++-+--+-+ > > > +| request | size | pay

Re: [Qemu-devel] [PATCH v6 05/11] vhost-user: add vhost_user_gpu_set_socket()

2019-04-26 Thread Marc-André Lureau
Hi On Fri, Apr 26, 2019 at 9:33 AM Gerd Hoffmann wrote: > > On Tue, Apr 23, 2019 at 03:19:58PM +0200, Marc-André Lureau wrote: > > Add a new vhost-user message to give a unix socket to a vhost-user > > backend for GPU display updates. > > Can you split input/gpu into two patch series? > > > +Wire

Re: [Qemu-devel] [PATCH v6 05/11] vhost-user: add vhost_user_gpu_set_socket()

2019-04-26 Thread Gerd Hoffmann
On Tue, Apr 23, 2019 at 03:19:58PM +0200, Marc-André Lureau wrote: > Add a new vhost-user message to give a unix socket to a vhost-user > backend for GPU display updates. Can you split input/gpu into two patch series? > +Wire format > +=== > + > +Unless specified differently, numbers are

[Qemu-devel] [PATCH v6 05/11] vhost-user: add vhost_user_gpu_set_socket()

2019-04-23 Thread Marc-André Lureau
Add a new vhost-user message to give a unix socket to a vhost-user backend for GPU display updates. Back when I started that work, I added a new GPU channel because the vhost-user protocol wasn't bidirectional. Since then, there is a vhost-user-slave channel for the slave to send requests to the m