Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing

2016-05-31 Thread Fam Zheng
On Tue, 05/31 14:48, Paolo Bonzini wrote: > > > On 31/05/2016 14:40, Fam Zheng wrote: > > > I'm still a bit undecided about the pollution introduced by > > > tests/docker/Makefile.include, but I guess that's okay. > > > > I think it's also okay to switch to "make -C tests/docker" for docker > >

Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing

2016-05-31 Thread Paolo Bonzini
On 31/05/2016 14:40, Fam Zheng wrote: > > I'm still a bit undecided about the pollution introduced by > > tests/docker/Makefile.include, but I guess that's okay. > > I think it's also okay to switch to "make -C tests/docker" for docker targets > (so "make docker" becomes "make -C tests/docker he

Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing

2016-05-31 Thread Fam Zheng
On Tue, 05/31 14:02, Paolo Bonzini wrote: > > > On 31/05/2016 13:00, Fam Zheng wrote: > > On Tue, 05/31 10:51, Paolo Bonzini wrote: > >>> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include > >>> new file mode 100644 > >>> index 000..372733d > >>> --- /dev/null > >>> ++

Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing

2016-05-31 Thread Paolo Bonzini
On 31/05/2016 13:00, Fam Zheng wrote: > On Tue, 05/31 10:51, Paolo Bonzini wrote: >>> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include >>> new file mode 100644 >>> index 000..372733d >>> --- /dev/null >>> +++ b/tests/docker/Makefile.include >>> @@ -0,0 +1,121 @@ >>>

Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing

2016-05-31 Thread Fam Zheng
On Tue, 05/31 10:51, Paolo Bonzini wrote: > > diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include > > new file mode 100644 > > index 000..372733d > > --- /dev/null > > +++ b/tests/docker/Makefile.include > > @@ -0,0 +1,121 @@ > > +# Makefile for Docker tests > > + > > +in

Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing

2016-05-31 Thread Paolo Bonzini
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include > new file mode 100644 > index 000..372733d > --- /dev/null > +++ b/tests/docker/Makefile.include > @@ -0,0 +1,121 @@ > +# Makefile for Docker tests > + > +include $(SRC_PATH)/rules.mak Why include this _and_ include

[Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing

2016-05-27 Thread Fam Zheng
This adds a group of make targets to run docker tests, all are available in source tree without running ./configure. The usage is shown with "make docker". Besides the fixed ones, dynamic targets for building each image and running each test in each image are generated automatically by make, scan