Re: [Qemu-devel] [PATCH v6 04/11] dump: Add API to write elf notes to buffer

2014-01-06 Thread Qiao Nuohan
On 01/07/2014 02:46 AM, Laszlo Ersek wrote: static int dump_cleanup(DumpState *s) > @@ -754,6 +757,22 @@ static int write_buffer(int fd, bool flag_flatten, off_t offset, void *buf, >return 0; >} > > +static int buf_write_note(void *buf, size_t size, void *opaque) > +{ "const vo

Re: [Qemu-devel] [PATCH v6 04/11] dump: Add API to write elf notes to buffer

2014-01-06 Thread Laszlo Ersek
some tangential comments: On 01/05/14 08:27, Qiao Nuohan wrote: > the function can be used by write_elf32_notes/write_elf64_notes to write notes > to a buffer. If fd_write_vmcore is used, write_elf32_notes/write_elf64_notes > will write elf notes to vmcore directly. Instead, if buf_write_note is u

[Qemu-devel] [PATCH v6 04/11] dump: Add API to write elf notes to buffer

2014-01-05 Thread Qiao Nuohan
the function can be used by write_elf32_notes/write_elf64_notes to write notes to a buffer. If fd_write_vmcore is used, write_elf32_notes/write_elf64_notes will write elf notes to vmcore directly. Instead, if buf_write_note is used, elf notes will be written to opaque->note_buf at first. Signed-of