Markus Armbruster writes:
> Peter Xu writes:
>
>> In the whole QAPI event emission code we're passing in an Error* object
>> along the whole stack. That's never useful since it never fails after
>> all. Remove that.
>
> This is the interesting part. We'll see below why it can't fail.
>
>> The
On Mon, Aug 27, 2018 at 02:14:25PM +0200, Markus Armbruster wrote:
[...]
> Let's improve the commit message a bit. Here's my try:
>
> qapi: Drop qapi_event_send_FOO()'s Error ** argument
>
> The generated qapi_event_send_FOO() take an Error ** argument. They
> can't actually fail,
Peter Xu writes:
> In the whole QAPI event emission code we're passing in an Error* object
> along the whole stack. That's never useful since it never fails after
> all. Remove that.
This is the interesting part. We'll see below why it can't fail.
> Then, remove that parameter from all the c
In the whole QAPI event emission code we're passing in an Error* object
along the whole stack. That's never useful since it never fails after
all. Remove that.
Then, remove that parameter from all the callers to send an event.
Suggested-by: Eric Blake
Suggested-by: Markus Armbruster
Signed-of
