Re: [Qemu-devel] [PATCH v6] Add compare subcommand for qemu-img

2012-12-11 Thread Miroslav Rezanina
Hi Kevin, thanks for review, comments inline. - Original Message - > From: "Kevin Wolf" > To: "Miroslav Rezanina" > Cc: qemu-devel@nongnu.org, "Paolo Bonzini" , "Stefan > Hajnoczi" > Sent: Tuesday, December 11, 2012 1:27:45 PM > Subject: Re: [PATCH v6] Add compare subcommand for qemu-i

Re: [Qemu-devel] [PATCH v6] Add compare subcommand for qemu-img

2012-12-11 Thread Kevin Wolf
Am 06.12.2012 13:24, schrieb Miroslav Rezanina: > This is second version of patch adding compare subcommand that > compares two images. Compare has following criteria: > - only data part is compared > - unallocated sectors are not read > - in case of different image size, exceeding part of bigg

Re: [Qemu-devel] [PATCH v6] Add compare subcommand for qemu-img

2012-12-11 Thread Stefan Hajnoczi
On Thu, Dec 06, 2012 at 07:24:04AM -0500, Miroslav Rezanina wrote: > This is second version of patch adding compare subcommand that > compares two images. Compare has following criteria: > - only data part is compared > - unallocated sectors are not read > - in case of different image size, exc

[Qemu-devel] [PATCH v6] Add compare subcommand for qemu-img

2012-12-06 Thread Miroslav Rezanina
This is second version of patch adding compare subcommand that compares two images. Compare has following criteria: - only data part is compared - unallocated sectors are not read - in case of different image size, exceeding part of bigger disk has to be zeroed/unallocated to compare rest - q