Re: [Qemu-devel] [PATCH v5 6/7] block: add generic full disk encryption driver

2016-03-23 Thread Eric Blake
On 03/18/2016 09:19 AM, Kevin Wolf wrote: +ov = opts_visitor_new(opts); + +visit_start_struct(opts_get_visitor(ov), + "luks", NULL, 0, &local_err); >>> >>> As this refers to "luks" specifically, shouldn't it be inside the switch >>> below? >> >> Or

Re: [Qemu-devel] [PATCH v5 6/7] block: add generic full disk encryption driver

2016-03-19 Thread Daniel P. Berrange
On Fri, Mar 18, 2016 at 03:37:12PM +, Daniel P. Berrange wrote: > On Fri, Mar 18, 2016 at 04:19:07PM +0100, Kevin Wolf wrote: > > Am 18.03.2016 um 15:45 hat Daniel P. Berrange geschrieben: > > > On Fri, Mar 18, 2016 at 01:09:35PM +0100, Kevin Wolf wrote: > > > > Am 17.03.2016 um 18:51 hat Danie

Re: [Qemu-devel] [PATCH v5 6/7] block: add generic full disk encryption driver

2016-03-19 Thread Kevin Wolf
Am 17.03.2016 um 18:51 hat Daniel P. Berrange geschrieben: > Add a block driver that is capable of supporting any full disk > encryption format. This utilizes the previously added block > encryption code, and at this time supports the LUKS format. > > The driver code is capable of supporting any f

Re: [Qemu-devel] [PATCH v5 6/7] block: add generic full disk encryption driver

2016-03-19 Thread Kevin Wolf
Am 18.03.2016 um 15:45 hat Daniel P. Berrange geschrieben: > On Fri, Mar 18, 2016 at 01:09:35PM +0100, Kevin Wolf wrote: > > Am 17.03.2016 um 18:51 hat Daniel P. Berrange geschrieben: > > > Add a block driver that is capable of supporting any full disk > > > encryption format. This utilizes the pre

Re: [Qemu-devel] [PATCH v5 6/7] block: add generic full disk encryption driver

2016-03-19 Thread Daniel P. Berrange
On Fri, Mar 18, 2016 at 04:19:07PM +0100, Kevin Wolf wrote: > Am 18.03.2016 um 15:45 hat Daniel P. Berrange geschrieben: > > On Fri, Mar 18, 2016 at 01:09:35PM +0100, Kevin Wolf wrote: > > > Am 17.03.2016 um 18:51 hat Daniel P. Berrange geschrieben: > > > > +ret = bdrv_co_readv(bs->file->bs

Re: [Qemu-devel] [PATCH v5 6/7] block: add generic full disk encryption driver

2016-03-18 Thread Daniel P. Berrange
On Fri, Mar 18, 2016 at 01:09:35PM +0100, Kevin Wolf wrote: > Am 17.03.2016 um 18:51 hat Daniel P. Berrange geschrieben: > > Add a block driver that is capable of supporting any full disk > > encryption format. This utilizes the previously added block > > encryption code, and at this time supports