Re: [Qemu-devel] [PATCH v5 6/6] qapi: convert sendkey

2012-08-03 Thread Luiz Capitulino
On Thu, 2 Aug 2012 21:38:00 -0400 (EDT) Amos Kong wrote: > - Original Message - > > On Thu, 26 Jul 2012 12:49:01 +0800 > > Amos Kong wrote: > > > > > Convert 'sendkey' to use QAPI. > > > > > > Keys' indexes in the enmu are same as keycodes' indexes in the > > > key_defs[], index_from_c

Re: [Qemu-devel] [PATCH v5 6/6] qapi: convert sendkey

2012-08-02 Thread Amos Kong
- Original Message - > On Thu, 26 Jul 2012 12:49:01 +0800 > Amos Kong wrote: > > > Convert 'sendkey' to use QAPI. > > > > Keys' indexes in the enmu are same as keycodes' indexes in the > > key_defs[], index_from_code() and index_from_key() will return > > Q_KEY_CODE_MAX if the code/key i

Re: [Qemu-devel] [PATCH v5 6/6] qapi: convert sendkey

2012-08-02 Thread Luiz Capitulino
On Thu, 26 Jul 2012 12:49:01 +0800 Amos Kong wrote: > Convert 'sendkey' to use QAPI. > > Keys' indexes in the enmu are same as keycodes' indexes in the > key_defs[], index_from_code() and index_from_key() will return > Q_KEY_CODE_MAX if the code/key is invalid. > > For qmp, QAPI would check inv

Re: [Qemu-devel] [PATCH v5 6/6] qapi: convert sendkey

2012-07-26 Thread Eric Blake
On 07/25/2012 10:49 PM, Amos Kong wrote: > Convert 'sendkey' to use QAPI. > > Keys' indexes in the enmu are same as keycodes' indexes in the s/enmu/enum/ > key_defs[], index_from_code() and index_from_key() will return > Q_KEY_CODE_MAX if the code/key is invalid. > > For qmp, QAPI would check i

[Qemu-devel] [PATCH v5 6/6] qapi: convert sendkey

2012-07-25 Thread Amos Kong
Convert 'sendkey' to use QAPI. Keys' indexes in the enmu are same as keycodes' indexes in the key_defs[], index_from_code() and index_from_key() will return Q_KEY_CODE_MAX if the code/key is invalid. For qmp, QAPI would check invalid key and raise error. For hmp, invalid key is checked in hmp_sen