On 24/05/2016 09:17, Igor Mammedov wrote:
> > Don't overuse stubs. The stubs library is mostly to share code between
> > QEMU and the tools. What Corey did is more similar to what hw/ already
> > does in other places.
>
> So what's the rule when one should use stubs or not?
If you have a conf
On 23/05/2016 21:25, Corey Minyard wrote:
>> Don't overuse stubs. The stubs library is mostly to share code between
>> QEMU and the tools. What Corey did is more similar to what hw/ already
>> does in other places.
>
> Should I change it back?
Yes, please. Sorry.
Thanks,
Paolo
On Mon, 23 May 2016 20:06:57 +0200
Paolo Bonzini wrote:
> On 20/05/2016 11:53, Igor Mammedov wrote:
> >> > diff --git a/hw/acpi/noipmi.c b/hw/acpi/noipmi.c
> >> > new file mode 100644
> >> > index 000..dd7590d
> >> > --- /dev/null
> >> > +++ b/hw/acpi/noipmi.c
> > move this to .a/stubs/
> >
On 05/23/2016 01:06 PM, Paolo Bonzini wrote:
On 20/05/2016 11:53, Igor Mammedov wrote:
diff --git a/hw/acpi/noipmi.c b/hw/acpi/noipmi.c
new file mode 100644
index 000..dd7590d
--- /dev/null
+++ b/hw/acpi/noipmi.c
move this to .a/stubs/
Don't overuse stubs. The stubs library is mostly to
On 20/05/2016 11:53, Igor Mammedov wrote:
>> > diff --git a/hw/acpi/noipmi.c b/hw/acpi/noipmi.c
>> > new file mode 100644
>> > index 000..dd7590d
>> > --- /dev/null
>> > +++ b/hw/acpi/noipmi.c
> move this to .a/stubs/
>
Don't overuse stubs. The stubs library is mostly to share code between
On 05/23/2016 08:51 AM, Marcel Apfelbaum wrote:
On 05/23/2016 04:39 PM, Corey Minyard wrote:
On 05/23/2016 04:05 AM, Marcel Apfelbaum wrote:
On 05/22/2016 03:28 AM, Corey Minyard wrote:
Thanks for all the comments. I didn't know about stubs, as
there's nothing that currently uses it in hw dir
On 05/23/2016 04:39 PM, Corey Minyard wrote:
On 05/23/2016 04:05 AM, Marcel Apfelbaum wrote:
On 05/22/2016 03:28 AM, Corey Minyard wrote:
Thanks for all the comments. I didn't know about stubs, as
there's nothing that currently uses it in hw directory, but
it's easy enough to add. I did have
On 05/23/2016 04:05 AM, Marcel Apfelbaum wrote:
On 05/22/2016 03:28 AM, Corey Minyard wrote:
Thanks for all the comments. I didn't know about stubs, as
there's nothing that currently uses it in hw directory, but
it's easy enough to add. I did have two comment below:
On 05/20/2016 04:53 AM, Ig
On Mon, 23 May 2016 07:42:32 -0500
Corey Minyard wrote:
> On 05/23/2016 05:01 AM, Igor Mammedov wrote:
> > On Sat, 21 May 2016 19:28:59 -0500
> > Corey Minyard wrote:
> >
> >> Thanks for all the comments. I didn't know about stubs, as
> >> there's nothing that currently uses it in hw director
On 05/23/2016 05:01 AM, Igor Mammedov wrote:
On Sat, 21 May 2016 19:28:59 -0500
Corey Minyard wrote:
Thanks for all the comments. I didn't know about stubs, as
there's nothing that currently uses it in hw directory, but
it's easy enough to add. I did have two comment below:
On 05/20/2016 04
On Sat, 21 May 2016 19:28:59 -0500
Corey Minyard wrote:
> Thanks for all the comments. I didn't know about stubs, as
> there's nothing that currently uses it in hw directory, but
> it's easy enough to add. I did have two comment below:
>
> On 05/20/2016 04:53 AM, Igor Mammedov wrote:
> > On Th
On 05/22/2016 03:28 AM, Corey Minyard wrote:
Thanks for all the comments. I didn't know about stubs, as
there's nothing that currently uses it in hw directory, but
it's easy enough to add. I did have two comment below:
On 05/20/2016 04:53 AM, Igor Mammedov wrote:
On Thu, 19 May 2016 10:24:01
Thanks for all the comments. I didn't know about stubs, as
there's nothing that currently uses it in hw directory, but
it's easy enough to add. I did have two comment below:
On 05/20/2016 04:53 AM, Igor Mammedov wrote:
On Thu, 19 May 2016 10:24:01 -0500
miny...@acm.org wrote:
.
.
.
+aml
On Thu, 19 May 2016 10:24:01 -0500
miny...@acm.org wrote:
> From: Corey Minyard
>
> Use the new ACPI table construction tools to create an ACPI
> entry for IPMI. This adds a function called from build_dsdt
> to add an DSDT entry for IPMI if IPMI is compiled in and has
> registered firmware. It
From: Corey Minyard
Use the new ACPI table construction tools to create an ACPI
entry for IPMI. This adds a function called from build_dsdt
to add an DSDT entry for IPMI if IPMI is compiled in and has
registered firmware. It also adds a dummy function if IPMI
is not compiled in.
This conforms
15 matches
Mail list logo
