Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-23 Thread Peter Xu
On Wed, May 23, 2018 at 05:15:26PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Wed, May 23, 2018 at 10:29:37AM +0200, Markus Armbruster wrote: > >> Peter Xu writes: > >> > >> > On Thu, May 17, 2018 at 02:46:36PM +0200, Markus Armbruster wrote: > >> >> Peter Xu writes: > >> >>

Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-23 Thread Markus Armbruster
Peter Xu writes: > On Wed, May 23, 2018 at 10:29:37AM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > On Thu, May 17, 2018 at 02:46:36PM +0200, Markus Armbruster wrote: >> >> Peter Xu writes: >> >> >> >> > Add some explicit comment for both Readline and cpu_set/cpu_get helpers >>

Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-23 Thread Peter Xu
On Wed, May 23, 2018 at 10:29:37AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Thu, May 17, 2018 at 02:46:36PM +0200, Markus Armbruster wrote: > >> Peter Xu writes: > >> > >> > Add some explicit comment for both Readline and cpu_set/cpu_get helpers > >> > that they do not need t

Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-23 Thread Markus Armbruster
Peter Xu writes: > On Thu, May 17, 2018 at 02:46:36PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > Add some explicit comment for both Readline and cpu_set/cpu_get helpers >> > that they do not need the mon_lock protection. >> >> Appreciated! >> >> > Signed-off-by: Peter Xu >>

Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-18 Thread Peter Xu
On Thu, May 17, 2018 at 02:46:36PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Add some explicit comment for both Readline and cpu_set/cpu_get helpers > > that they do not need the mon_lock protection. > > Appreciated! > > > Signed-off-by: Peter Xu > > --- > > monitor.c | 5 +++--

Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-17 Thread Markus Armbruster
Peter Xu writes: > Add some explicit comment for both Readline and cpu_set/cpu_get helpers > that they do not need the mon_lock protection. Appreciated! > Signed-off-by: Peter Xu > --- > monitor.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/monitor.c b/monito

Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-10 Thread Stefan Hajnoczi
On Wed, May 09, 2018 at 12:17:33PM +0800, Peter Xu wrote: > Add some explicit comment for both Readline and cpu_set/cpu_get helpers > that they do not need the mon_lock protection. > > Signed-off-by: Peter Xu > --- > monitor.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewe

[Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-08 Thread Peter Xu
Add some explicit comment for both Readline and cpu_set/cpu_get helpers that they do not need the mon_lock protection. Signed-off-by: Peter Xu --- monitor.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index d6c3c08932..ae5bca9d7c 100644 --- a/mo