Re: [Qemu-devel] [PATCH v5 22/24] target/arm: Implement ARMv8.5-RNG

2019-05-10 Thread Richard Henderson
On 5/10/19 9:20 AM, Peter Maydell wrote: > On Fri, 10 May 2019 at 17:17, Richard Henderson > wrote: >> >> On 5/10/19 9:01 AM, Peter Maydell wrote: >>> Don't these need to be marked ARM_CP_IO for the benefit >>> of -icount ? >> >> I don't think so. There's no lock taken, as for mmio devices. It's

Re: [Qemu-devel] [PATCH v5 22/24] target/arm: Implement ARMv8.5-RNG

2019-05-10 Thread Richard Henderson
On 5/10/19 9:01 AM, Peter Maydell wrote: > On Fri, 10 May 2019 at 02:25, Richard Henderson > wrote: >> >> Cc: qemu-...@nongnu.org >> Cc: Peter Maydell >> Signed-off-by: Richard Henderson >> --- >> v3: Log errors with -d unimp, for lack of a better flag. >> --- >> target/arm/cpu.h| 5 +

Re: [Qemu-devel] [PATCH v5 22/24] target/arm: Implement ARMv8.5-RNG

2019-05-10 Thread Peter Maydell
On Fri, 10 May 2019 at 17:17, Richard Henderson wrote: > > On 5/10/19 9:01 AM, Peter Maydell wrote: > > Don't these need to be marked ARM_CP_IO for the benefit > > of -icount ? > > I don't think so. There's no lock taken, as for mmio devices. It's not not > related to time, virtual or otherwise.

Re: [Qemu-devel] [PATCH v5 22/24] target/arm: Implement ARMv8.5-RNG

2019-05-10 Thread Peter Maydell
On Fri, 10 May 2019 at 02:25, Richard Henderson wrote: > > Cc: qemu-...@nongnu.org > Cc: Peter Maydell > Signed-off-by: Richard Henderson > --- > v3: Log errors with -d unimp, for lack of a better flag. > --- > target/arm/cpu.h| 5 + > target/arm/cpu64.c | 1 + > target/arm/helper.c

[Qemu-devel] [PATCH v5 22/24] target/arm: Implement ARMv8.5-RNG

2019-05-09 Thread Richard Henderson
Cc: qemu-...@nongnu.org Cc: Peter Maydell Signed-off-by: Richard Henderson --- v3: Log errors with -d unimp, for lack of a better flag. --- target/arm/cpu.h| 5 + target/arm/cpu64.c | 1 + target/arm/helper.c | 44 3 files changed, 50 inser