Re: [Qemu-devel] [PATCH v5 18/24] ssd0323: fix buffer overun on invalid state load

2014-04-03 Thread Peter Maydell
On 3 April 2014 17:52, Michael S. Tsirkin wrote: > CVE-2013-4538 > > s->cmd_len used as index in ssd0323_transfer() to store 32-bit field. > Possible this field might then be supplied by guest to overwrite a > return addr somewhere. Same for row/col fields, which are indicies into > framebuffer ar

[Qemu-devel] [PATCH v5 18/24] ssd0323: fix buffer overun on invalid state load

2014-04-03 Thread Michael S. Tsirkin
CVE-2013-4538 s->cmd_len used as index in ssd0323_transfer() to store 32-bit field. Possible this field might then be supplied by guest to overwrite a return addr somewhere. Same for row/col fields, which are indicies into framebuffer array. To fix validate after load. Additionally, validate tha