Re: [Qemu-devel] [PATCH v5 10/46] qapi: Merge generation of per-member visits

2015-09-29 Thread Markus Armbruster
Eric Blake writes: > On 09/28/2015 12:17 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Consolidate the code between visit, command marshalling, and >>> event generation that iterates over the members of a struct. >>> It reduces code duplication in the generator, with no change to >>

Re: [Qemu-devel] [PATCH v5 10/46] qapi: Merge generation of per-member visits

2015-09-28 Thread Eric Blake
On 09/28/2015 12:17 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Consolidate the code between visit, command marshalling, and >> event generation that iterates over the members of a struct. >> It reduces code duplication in the generator, with no change to >> generated marshal code, sli

Re: [Qemu-devel] [PATCH v5 10/46] qapi: Merge generation of per-member visits

2015-09-27 Thread Markus Armbruster
Eric Blake writes: > Consolidate the code between visit, command marshalling, and > event generation that iterates over the members of a struct. > It reduces code duplication in the generator, with no change to > generated marshal code, slightly more verbose visit code: > > | visit_optional(v

[Qemu-devel] [PATCH v5 10/46] qapi: Merge generation of per-member visits

2015-09-21 Thread Eric Blake
Consolidate the code between visit, command marshalling, and event generation that iterates over the members of a struct. It reduces code duplication in the generator, with no change to generated marshal code, slightly more verbose visit code: | visit_optional(v, &(*obj)->has_device, "device",