Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-14 Thread gengdongjiu
Hi Michael Thanks for your comments. > -邮件原件- > 发件人: Michael S. Tsirkin [mailto:m...@redhat.com] > 主题: Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and > macros > > On Thu, Jul 13, 2017 at 08:00:26PM +0800, gengdongjiu wrote: > >Laszlo, I p

Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-14 Thread gengdongjiu
Michael, thanks for the review and comments. On 2017/7/14 1:11, Michael S. Tsirkin wrote: > On Wed, Jul 12, 2017 at 10:08:15AM +0800, Dongjiu Geng wrote: >> (1) Add related APEI/HEST table structures and macros, these >> definition refer to ACPI 6.1 and UEFI 2.6 spec. >> (2) Add generic err

Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-14 Thread gengdongjiu
Dear Michael, On 2017/7/14 1:13, Michael S. Tsirkin wrote: > On Thu, Jul 13, 2017 at 05:33:30PM +0200, Laszlo Ersek wrote: >> On 07/13/17 14:00, gengdongjiu wrote: >>> Laszlo, >>> Thank you for your review and comments. >>> >>> >>> On 2017/7/13 18:33, Laszlo Ersek wrote: On 07/12/17 04:08,

Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-13 Thread gengdongjiu
Michael, Thanks for your review. On 2017/7/14 1:01, Michael S. Tsirkin wrote: >> +typedef struct GhesState { >> +uint64_t ghes_addr_le; >> +} GhesState; >> + >> +void ghes_build_acpi(GArray *table_data, GArray *hardware_error, >> +BIOSLinker *linker); >> +void gh

Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-13 Thread Michael S. Tsirkin
On Thu, Jul 13, 2017 at 08:00:26PM +0800, gengdongjiu wrote: >Laszlo, I pasted Michael's comments here, as shown below. Michael said the > definition > should use build_append_int_noprefix to add data. but I think it may not > good, becuase > the section "UEFI_CPER_SEC_PLATFORM_MEM" is runtim

Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-13 Thread Michael S. Tsirkin
On Thu, Jul 13, 2017 at 05:33:30PM +0200, Laszlo Ersek wrote: > On 07/13/17 14:00, gengdongjiu wrote: > > Laszlo, > > Thank you for your review and comments. > > > > > > On 2017/7/13 18:33, Laszlo Ersek wrote: > >> On 07/12/17 04:08, Dongjiu Geng wrote: > > [snip] > > >>> --- a/include/qemu/u

Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-13 Thread Michael S. Tsirkin
On Wed, Jul 12, 2017 at 10:08:15AM +0800, Dongjiu Geng wrote: > (1) Add related APEI/HEST table structures and macros, these > definition refer to ACPI 6.1 and UEFI 2.6 spec. > (2) Add generic error status block and CPER memory section > definition, user space only handle memory section er

Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-13 Thread Michael S. Tsirkin
On Wed, Jul 12, 2017 at 10:08:15AM +0800, Dongjiu Geng wrote: > (1) Add related APEI/HEST table structures and macros, these > definition refer to ACPI 6.1 and UEFI 2.6 spec. > (2) Add generic error status block and CPER memory section > definition, user space only handle memory section er

Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-13 Thread Laszlo Ersek
On 07/13/17 14:00, gengdongjiu wrote: > Laszlo, > Thank you for your review and comments. > > > On 2017/7/13 18:33, Laszlo Ersek wrote: >> On 07/12/17 04:08, Dongjiu Geng wrote: [snip] >>> --- a/include/qemu/uuid.h >>> +++ b/include/qemu/uuid.h >>> @@ -44,6 +44,17 @@ typedef struct { >>> >>

Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-13 Thread gengdongjiu
Laszlo, Thank you for your review and comments. On 2017/7/13 18:33, Laszlo Ersek wrote: > On 07/12/17 04:08, Dongjiu Geng wrote: >> (1) Add related APEI/HEST table structures and macros, these >> definition refer to ACPI 6.1 and UEFI 2.6 spec. >> (2) Add generic error status block and CPER

Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-13 Thread Laszlo Ersek
On 07/12/17 04:08, Dongjiu Geng wrote: > (1) Add related APEI/HEST table structures and macros, these > definition refer to ACPI 6.1 and UEFI 2.6 spec. > (2) Add generic error status block and CPER memory section > definition, user space only handle memory section errors. > > Signed-off-b

[Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-11 Thread Dongjiu Geng
(1) Add related APEI/HEST table structures and macros, these definition refer to ACPI 6.1 and UEFI 2.6 spec. (2) Add generic error status block and CPER memory section definition, user space only handle memory section errors. Signed-off-by: Dongjiu Geng --- thanks Laszlo and Michael's re