Re: [Qemu-devel] [PATCH v5 1/2] pl330: Initial version

2012-10-30 Thread Avi Kivity
On 10/30/2012 03:42 PM, Peter Crosthwaite wrote: > On Tue, Oct 30, 2012 at 7:51 PM, Avi Kivity wrote: >> On 10/29/2012 10:32 AM, Peter Maydell wrote: >>> On 29 October 2012 06:35, Peter Crosthwaite >>> wrote: Device model for Primecell PL330 dma controller. >>> >>> A general question -- this

Re: [Qemu-devel] [PATCH v5 1/2] pl330: Initial version

2012-10-30 Thread Peter Crosthwaite
On Tue, Oct 30, 2012 at 7:51 PM, Avi Kivity wrote: > On 10/29/2012 10:32 AM, Peter Maydell wrote: >> On 29 October 2012 06:35, Peter Crosthwaite >> wrote: >>> Device model for Primecell PL330 dma controller. >> >> A general question -- this is a DMA controller so should it be using >> the DMACont

Re: [Qemu-devel] [PATCH v5 1/2] pl330: Initial version

2012-10-30 Thread Avi Kivity
On 10/29/2012 10:32 AM, Peter Maydell wrote: > On 29 October 2012 06:35, Peter Crosthwaite > wrote: >> Device model for Primecell PL330 dma controller. > > A general question -- this is a DMA controller so should it be using > the DMAContext APIs now? Avi? IOMMU functionality will be folded into

Re: [Qemu-devel] [PATCH v5 1/2] pl330: Initial version

2012-10-29 Thread Peter Crosthwaite
All changed made, Thanks, Peter On Mon, Oct 29, 2012 at 7:41 PM, Igor Mitsyanko wrote: > Good day, Peter) > > > On 10/29/2012 10:35 AM, Peter Crosthwaite wrote: >> >> Device model for Primecell PL330 dma controller. >> >> + >> +static Property pl330_properties[] = { >> +/* CR0 */ >> +DEF

Re: [Qemu-devel] [PATCH v5 1/2] pl330: Initial version

2012-10-29 Thread Peter Crosthwaite
All changed made Thanks, Peter On Mon, Oct 29, 2012 at 6:32 PM, Peter Maydell wrote: > On 29 October 2012 06:35, Peter Crosthwaite > wrote: >> Device model for Primecell PL330 dma controller. > > A general question -- this is a DMA controller so should it be using > the DMAContext APIs now? Avi

Re: [Qemu-devel] [PATCH v5 1/2] pl330: Initial version

2012-10-29 Thread Igor Mitsyanko
Good day, Peter) On 10/29/2012 10:35 AM, Peter Crosthwaite wrote: Device model for Primecell PL330 dma controller. + +static Property pl330_properties[] = { +/* CR0 */ +DEFINE_PROP_UINT8("num_chnls", PL330, num_chnls, 8), +DEFINE_PROP_UINT8("num_periph_req", PL330, num_periph_req, 8

Re: [Qemu-devel] [PATCH v5 1/2] pl330: Initial version

2012-10-29 Thread Peter Maydell
On 29 October 2012 06:35, Peter Crosthwaite wrote: > Device model for Primecell PL330 dma controller. A general question -- this is a DMA controller so should it be using the DMAContext APIs now? Avi? > +static void pl330_queue_init(PL330Queue *s, int size, int channum) > +{ > +s->queue = (P

[Qemu-devel] [PATCH v5 1/2] pl330: Initial version

2012-10-28 Thread Peter Crosthwaite
Device model for Primecell PL330 dma controller. Signed-off-by: Kirill Batuzov Tested-by: Igor Mitsyanko Signed-off-by: Peter Crosthwaite --- changed from v4: Various cosmetic fixes Some Makefile refactoring updates refactored properties to match primecell options rather than be the config regi