Re: [Qemu-devel] [PATCH v5 09/46] qapi: Use consistent generated code patterns

2015-09-25 Thread Eric Blake
On 09/25/2015 10:54 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We had some pointless differences in the generated code for visit, >> command marshalling, and events; unifying them makes it easier for >> future patches to consolidate to common helper functions. >> - Consistently name t

Re: [Qemu-devel] [PATCH v5 09/46] qapi: Use consistent generated code patterns

2015-09-25 Thread Markus Armbruster
Eric Blake writes: > We had some pointless differences in the generated code for visit, > command marshalling, and events; unifying them makes it easier for > future patches to consolidate to common helper functions. > - Consistently name the error variable 'err' Before the patch, qapi-event.py

[Qemu-devel] [PATCH v5 09/46] qapi: Use consistent generated code patterns

2015-09-21 Thread Eric Blake
We had some pointless differences in the generated code for visit, command marshalling, and events; unifying them makes it easier for future patches to consolidate to common helper functions. - Consistently name the error variable 'err' - Consistently use the labels 'out' and 'out_obj' - If allocat