Re: [Qemu-devel] [PATCH v5 08/17] target/m68k: add move16

2018-01-02 Thread Richard Henderson
On 01/02/2018 10:42 AM, Laurent Vivier wrote: > Le 02/01/2018 à 17:50, Richard Henderson a écrit : >> On 01/01/2018 05:10 PM, Laurent Vivier wrote: >>> +mode = (insn >> 3) & 7; >>> + >>> +if (mode & 4) { >> >> Looks like mode should equal 4 as well. >> > > Yes, you're right. I will replace

Re: [Qemu-devel] [PATCH v5 08/17] target/m68k: add move16

2018-01-02 Thread Laurent Vivier
Le 03/01/2018 à 00:49, Richard Henderson a écrit : > On 01/02/2018 10:42 AM, Laurent Vivier wrote: >> Le 02/01/2018 à 17:50, Richard Henderson a écrit : >>> On 01/01/2018 05:10 PM, Laurent Vivier wrote: +mode = (insn >> 3) & 7; + +if (mode & 4) { >>> >>> Looks like mode shoul

Re: [Qemu-devel] [PATCH v5 08/17] target/m68k: add move16

2018-01-02 Thread Laurent Vivier
Le 02/01/2018 à 17:50, Richard Henderson a écrit : > On 01/01/2018 05:10 PM, Laurent Vivier wrote: >> +mode = (insn >> 3) & 7; >> + >> +if (mode & 4) { > > Looks like mode should equal 4 as well. > Yes, you're right. I will replace the line by: +if (mode == 4) { Thanks, Laurent

Re: [Qemu-devel] [PATCH v5 08/17] target/m68k: add move16

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > +mode = (insn >> 3) & 7; > + > +if (mode & 4) { Looks like mode should equal 4 as well. r~

[Qemu-devel] [PATCH v5 08/17] target/m68k: add move16

2018-01-01 Thread Laurent Vivier
move16 moves the source line to the destination line. Lines are aligned to 16-byte boundaries and are 16 bytes long. Signed-off-by: Laurent Vivier --- target/m68k/cpu.c | 10 ++- target/m68k/cpu.h | 1 + target/m68k/translate.c | 73 ++