Re: [Qemu-devel] [PATCH v5 07/46] qapi: Don't pass pre-existing error to later call

2015-09-28 Thread Markus Armbruster
Eric Blake writes: > On 09/24/2015 08:58 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Due to the existing semantics of the error_set() family, >>> generated sequences in the qapi visitors such as: >>> >>> visit_start_implicit_struct(m, (void **)obj, sizeof(FOO), &err); >>>

Re: [Qemu-devel] [PATCH v5 07/46] qapi: Don't pass pre-existing error to later call

2015-09-28 Thread Markus Armbruster
Eric Blake writes: > On 09/24/2015 10:14 AM, Eric Blake wrote: > visit_start_implicit_struct(m, (void **)obj, sizeof(FOO), &err); if (!err) { visit_type_FOO_fields(m, obj, &err); visit_end_implicit_struct(m, err ? NULL : &err);

Re: [Qemu-devel] [PATCH v5 07/46] qapi: Don't pass pre-existing error to later call

2015-09-26 Thread Eric Blake
On 09/26/2015 03:41 PM, Eric Blake wrote: > On 09/24/2015 08:58 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Due to the existing semantics of the error_set() family, >>> generated sequences in the qapi visitors such as: >>> >>> visit_start_implicit_struct(m, (void **)obj, sizeof(F

Re: [Qemu-devel] [PATCH v5 07/46] qapi: Don't pass pre-existing error to later call

2015-09-26 Thread Eric Blake
On 09/24/2015 08:58 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Due to the existing semantics of the error_set() family, >> generated sequences in the qapi visitors such as: >> >> visit_start_implicit_struct(m, (void **)obj, sizeof(FOO), &err); >> if (!err) { >>

Re: [Qemu-devel] [PATCH v5 07/46] qapi: Don't pass pre-existing error to later call

2015-09-26 Thread Eric Blake
On 09/24/2015 10:14 AM, Eric Blake wrote: >>> >>> visit_start_implicit_struct(m, (void **)obj, sizeof(FOO), &err); >>> if (!err) { >>> visit_type_FOO_fields(m, obj, &err); >>> visit_end_implicit_struct(m, err ? NULL : &err); >>> } >>> error_propagate

Re: [Qemu-devel] [PATCH v5 07/46] qapi: Don't pass pre-existing error to later call

2015-09-24 Thread Eric Blake
On 09/24/2015 08:58 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Due to the existing semantics of the error_set() family, >> generated sequences in the qapi visitors such as: >> >> visit_start_implicit_struct(m, (void **)obj, sizeof(FOO), &err); >> if (!err) { >>

Re: [Qemu-devel] [PATCH v5 07/46] qapi: Don't pass pre-existing error to later call

2015-09-24 Thread Markus Armbruster
Eric Blake writes: > Due to the existing semantics of the error_set() family, > generated sequences in the qapi visitors such as: > > visit_start_implicit_struct(m, (void **)obj, sizeof(FOO), &err); > if (!err) { > visit_type_FOO_fields(m, obj, errp); > visit_e

[Qemu-devel] [PATCH v5 07/46] qapi: Don't pass pre-existing error to later call

2015-09-21 Thread Eric Blake
Due to the existing semantics of the error_set() family, generated sequences in the qapi visitors such as: visit_start_implicit_struct(m, (void **)obj, sizeof(FOO), &err); if (!err) { visit_type_FOO_fields(m, obj, errp); visit_end_implicit_struct(m, &err);