Re: [Qemu-devel] [PATCH v5 07/12] qemu-img: Empty images after commit

2014-04-24 Thread Max Reitz
On 23.04.2014 11:32, Kevin Wolf wrote: Am 22.04.2014 um 18:22 hat Max Reitz geschrieben: On 22.04.2014 17:19, Eric Blake wrote: On 04/17/2014 03:59 PM, Max Reitz wrote: After the top image has been committed into an image in its backing chain, all images above that base image should be emptied

Re: [Qemu-devel] [PATCH v5 07/12] qemu-img: Empty images after commit

2014-04-24 Thread Kevin Wolf
Am 24.04.2014 um 16:54 hat Max Reitz geschrieben: > On 23.04.2014 11:32, Kevin Wolf wrote: > >Am 22.04.2014 um 18:22 hat Max Reitz geschrieben: > >>On 22.04.2014 17:19, Eric Blake wrote: > >>>On 04/17/2014 03:59 PM, Max Reitz wrote: > After the top image has been committed into an image in its

Re: [Qemu-devel] [PATCH v5 07/12] qemu-img: Empty images after commit

2014-04-23 Thread Kevin Wolf
Am 22.04.2014 um 18:22 hat Max Reitz geschrieben: > On 22.04.2014 17:19, Eric Blake wrote: > >On 04/17/2014 03:59 PM, Max Reitz wrote: > >>After the top image has been committed into an image in its backing > >>chain, all images above that base image should be emptied to restore the > >>old qemu-im

Re: [Qemu-devel] [PATCH v5 07/12] qemu-img: Empty images after commit

2014-04-22 Thread Eric Blake
On 04/22/2014 12:01 PM, Max Reitz wrote: >> Thinking about it more, the ability to empty an image after commit >> should be optional, and exposed as an option for the user to control. >> >> In other words, I'm arguing that the ONLY time that leaving the active >> image empty after completing a co

Re: [Qemu-devel] [PATCH v5 07/12] qemu-img: Empty images after commit

2014-04-22 Thread Max Reitz
On 22.04.2014 19:48, Eric Blake wrote: On 04/22/2014 10:22 AM, Max Reitz wrote: On 22.04.2014 17:19, Eric Blake wrote: On 04/17/2014 03:59 PM, Max Reitz wrote: After the top image has been committed into an image in its backing chain, all images above that base image should be emptied to resto

Re: [Qemu-devel] [PATCH v5 07/12] qemu-img: Empty images after commit

2014-04-22 Thread Eric Blake
On 04/22/2014 10:22 AM, Max Reitz wrote: > On 22.04.2014 17:19, Eric Blake wrote: >> On 04/17/2014 03:59 PM, Max Reitz wrote: >>> After the top image has been committed into an image in its backing >>> chain, all images above that base image should be emptied to restore the >>> old qemu-img commit

Re: [Qemu-devel] [PATCH v5 07/12] qemu-img: Empty images after commit

2014-04-22 Thread Max Reitz
On 22.04.2014 18:22, Max Reitz wrote: On 22.04.2014 17:19, Eric Blake wrote: On 04/17/2014 03:59 PM, Max Reitz wrote: After the top image has been committed into an image in its backing chain, all images above that base image should be emptied to restore the old qemu-img commit behavior. Sig

Re: [Qemu-devel] [PATCH v5 07/12] qemu-img: Empty images after commit

2014-04-22 Thread Max Reitz
On 22.04.2014 17:19, Eric Blake wrote: On 04/17/2014 03:59 PM, Max Reitz wrote: After the top image has been committed into an image in its backing chain, all images above that base image should be emptied to restore the old qemu-img commit behavior. Signed-off-by: Max Reitz --- qemu-img.c |

Re: [Qemu-devel] [PATCH v5 07/12] qemu-img: Empty images after commit

2014-04-22 Thread Eric Blake
On 04/17/2014 03:59 PM, Max Reitz wrote: > After the top image has been committed into an image in its backing > chain, all images above that base image should be emptied to restore the > old qemu-img commit behavior. > > Signed-off-by: Max Reitz > --- > qemu-img.c | 87 > ++

[Qemu-devel] [PATCH v5 07/12] qemu-img: Empty images after commit

2014-04-17 Thread Max Reitz
After the top image has been committed into an image in its backing chain, all images above that base image should be emptied to restore the old qemu-img commit behavior. Signed-off-by: Max Reitz --- qemu-img.c | 87 +++--- 1 file changed,